== Series Details == Series: drm/i915: move display feature check macros out of i915_drv.h URL : https://patchwork.freedesktop.org/series/105381/ State : warning == Summary == Error: dim checkpatch failed 15d736930b6b drm/i915/display: spread out HAS_*() feature macros -:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #47: FILE: drivers/gpu/drm/i915/display/intel_cursor.c:27: +#define HAS_CUR_FBC(__i915) (!HAS_GMCH(__i915) && DISPLAY_VER(__i915) >= 7) -:87: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #87: FILE: drivers/gpu/drm/i915/display/intel_gmbus.c:42: +#define HAS_GMBUS_BURST_READ(__i915) \ + (DISPLAY_VER(__i915) >= 11 || IS_GEMINILAKE(__i915) || IS_KABYLAKE(__i915)) -:233: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #233: FILE: drivers/gpu/drm/i915/intel_pm.c:61: +#define HAS_HW_SAGV_WM(__i915) (DISPLAY_VER(__i915) >= 13 && !IS_DGFX(__i915)) total: 0 errors, 0 warnings, 3 checks, 169 lines checked bf2a38879dbd drm/i915/display: add intel_display_features.h for feature check macros Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:12: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #12: new file mode 100644 -:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #27: FILE: drivers/gpu/drm/i915/display/intel_display_features.h:11: +#define HAS_D12_PLANE_MINIMIZATION(__i915) (IS_ROCKETLAKE(__i915) || IS_ALDERLAKE_S(__i915)) -:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #29: FILE: drivers/gpu/drm/i915/display/intel_display_features.h:13: +#define HAS_HW_SAGV_WM(__i915) (DISPLAY_VER(__i915) >= 13 && !IS_DGFX(__i915)) -:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #30: FILE: drivers/gpu/drm/i915/display/intel_display_features.h:14: +#define HAS_IPS(__i915) (IS_HSW_ULT(__i915) || IS_BROADWELL(__i915)) -:35: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #35: FILE: drivers/gpu/drm/i915/display/intel_display_features.h:19: +#define HAS_DDI(__i915)^I^I ^I(INTEL_INFO(__i915)->display.has_ddi)$ -:41: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #41: FILE: drivers/gpu/drm/i915/display/intel_display_features.h:25: +#define HAS_PSR(__i915)^I^I ^I(INTEL_INFO(__i915)->display.has_psr)$ -:42: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #42: FILE: drivers/gpu/drm/i915/display/intel_display_features.h:26: +#define HAS_TRANSCODER(__i915, trans) ((INTEL_INFO(__i915)->display.cpu_transcoder_mask & BIT(trans)) != 0) -:48: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #48: FILE: drivers/gpu/drm/i915/display/intel_display_features.h:32: +#define INTEL_DISPLAY_ENABLED(__i915) \ + (drm_WARN_ON(&(__i915)->drm, !HAS_DISPLAY(__i915)), \ + !(__i915)->params.disable_display && \ + !intel_opregion_headless_sku(__i915)) total: 0 errors, 4 warnings, 4 checks, 164 lines checked
