Started pondering about this based on [1]. Spread out single-use and single-file-use HAS_*() macros, and move display macros to display/intel_display_features.h. Food for thought at least. Doesn't look too bad tbh. BR, Jani. [1] https://lore.kernel.org/r/YrCoxUgSEuzl+Amp@xxxxxxxxx Jani Nikula (2): drm/i915/display: spread out HAS_*() feature macros drm/i915/display: add intel_display_features.h for feature check macros drivers/gpu/drm/i915/display/intel_bios.c | 2 + drivers/gpu/drm/i915/display/intel_cdclk.c | 2 + drivers/gpu/drm/i915/display/intel_cursor.c | 2 + .../drm/i915/display/intel_display_features.h | 37 ++++++++++++ .../i915/display/intel_display_power_map.c | 5 +- .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dmc.c | 2 + drivers/gpu/drm/i915/display/intel_dsb.c | 2 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 4 ++ .../gpu/drm/i915/display/intel_lpe_audio.c | 1 + drivers/gpu/drm/i915/display/intel_overlay.c | 5 +- drivers/gpu/drm/i915/display/intel_psr.c | 3 + drivers/gpu/drm/i915/i915_drv.h | 60 ------------------- drivers/gpu/drm/i915/i915_suspend.c | 1 + drivers/gpu/drm/i915/intel_device_info.c | 1 + drivers/gpu/drm/i915/intel_dram.c | 1 + drivers/gpu/drm/i915/intel_pch.c | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 ++ 18 files changed, 68 insertions(+), 66 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_features.h -- 2.30.2