From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Several changes to our BDB block handling: 1) The current way of trusting the version checks to avoid out of bounds accesses to the BDB blocks is fragile. We might just get the version check wrong, or the VBT may be corrupted/malicious. So instead of doing blind accesses into the original data let's make a copy of each block with a gauranteed minimum size. 2) The LFP data table pointer stuff is a horrible mess currently. Let's make that sensible by verifying the pointers ahead of time, which allows us to trust them 100% when we acually parse the actual data block. 3) There's more stuff at the tail end of the LFP data block we need to parse. The variable size of the fp_timing table makes that a bit awkward, but with the pointer validation in place it's not too horrible. 4) Modern VBTs (seen it on TGL/ADL-P/CML so far) no longer include the LFP data table pointers block (41) in the VBT. In order to keep the rest of the code working as is we must therefore generate the pointers block from scratch. New stuff in v2: - Make all the BDB block copies up front - Split the VBT parsing into two parts and add the EDID PNPID->panel_type matching because many modern machines need it v3: - Some stuff already merged - Split out a few things - Address a bunch of review comments Ville Syrjälä (18): drm/i915/bios: Reorder panel DTD parsing drm/i915/bios: Generate LFP data table pointers if the VBT lacks them drm/i915/bios: Get access to the tail end of the LFP data block drm/i915/bios: Document the mess around the LFP data tables drm/i915/bios: Assume panel_type==0 if the VBT has bogus data drm/i915/bios: Split parse_driver_features() into two parts drm/i915/bios: Split VBT parsing to global vs. panel specific parts drm/i915/bios: Don't parse some panel specific data multiple times drm/i915/pps: Split PPS init+sanitize in two drm/i915/pps: Reinit PPS delays after VBT has been fully parsed drm/i915/bios: Do panel specific VBT parsing later drm/i915/bios: Extract get_panel_type() drm/i915/bios: Refactor panel_type code drm/i915/bios: Determine panel type via PNPID match drm/i915/bios: Parse the seamless DRRS min refresh rate drm/i915: Respect VBT seamless DRRS min refresh rate drm/edid: Extract drm_edid_decode_mfg_id() drm/i915/bios: Dump PNPID and panel name drivers/gpu/drm/i915/display/icl_dsi.c | 2 + drivers/gpu/drm/i915/display/intel_bios.c | 490 +++++++++++++++--- drivers/gpu/drm/i915/display/intel_bios.h | 3 + drivers/gpu/drm/i915/display/intel_dp.c | 4 + drivers/gpu/drm/i915/display/intel_lvds.c | 2 + drivers/gpu/drm/i915/display/intel_panel.c | 10 +- drivers/gpu/drm/i915/display/intel_pps.c | 35 +- drivers/gpu/drm/i915/display/intel_pps.h | 1 + drivers/gpu/drm/i915/display/intel_sdvo.c | 3 + drivers/gpu/drm/i915/display/intel_vbt_defs.h | 24 +- drivers/gpu/drm/i915/display/vlv_dsi.c | 2 + drivers/gpu/drm/i915/i915_drv.h | 1 + include/drm/drm_edid.h | 21 +- 13 files changed, 526 insertions(+), 72 deletions(-) -- 2.35.1
