On Sat, Nov 13, 2021 at 08:22:20AM -0800, Lucas De Marchi wrote:
On Fri, Nov 12, 2021 at 05:47:27PM -0800, Matt Roper wrote:
On Fri, Nov 12, 2021 at 05:42:28PM -0800, Michael Cheng wrote:
Thanks for the feed back! I feel like using something name GEN6 or BYT for a
platform that's not GEN6 or BYT could be a bit confusing, that's why we
decided to go with something more generic. I do agree I need to cite the
bspec more. Ill wait for more feedback before I send a new revision out.
In general that's the pattern that i915 tries to use --- we name
functions, macros, etc. after the first platform or generation that they
apply to and then continue to use them on all subsequent platforms until
the hardware changes again and we need a new version. E.g., we're still
calling "gen8_ppgtt_create" to create our PPGTTs on the latest
platforms, even though we're well past gen8 at this point.
I'd be totally ok with it if it was gen8 or gen6, but here the define is
BYT. But if it's only me who find strange using the BYT_ define, I'm
fine with it.
let's ignore that and go with the GEN6 + BYT defines. Please also Cc
dri-devel since this touches gt/ code.
thanks
Lucas De Marchi
