== Series Details == Series: drm/i915: Improve DP link training further (rev4) URL : https://patchwork.freedesktop.org/series/95405/ State : warning == Summary == $ dim checkpatch origin/drm-tip abef31c7b13c drm/i915: Tweak the DP "max vswing reached?" condition b54d2483d9e1 drm/i915: Show LTTPR in the TPS debug print 5799665e91f9 drm/i915: Print the DP vswing adjustment request -:25: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #25: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:349: +#define TRAIN_REQ_VSWING_ARGS(link_status) \ + _TRAIN_REQ_VSWING_ARGS(link_status, 0), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 1), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 2), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 3) -:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'link_status' - possible side-effects? #25: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:349: +#define TRAIN_REQ_VSWING_ARGS(link_status) \ + _TRAIN_REQ_VSWING_ARGS(link_status, 0), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 1), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 2), \ + _TRAIN_REQ_VSWING_ARGS(link_status, 3) -:31: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #31: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:355: + (drm_dp_get_adjust_request_pre_emphasis((link_status), (lane)) >> DP_TRAIN_PRE_EMPHASIS_SHIFT) -:32: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #32: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:356: +#define TRAIN_REQ_PREEMPH_ARGS(link_status) \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 0), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 1), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 2), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 3) -:32: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'link_status' - possible side-effects? #32: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:356: +#define TRAIN_REQ_PREEMPH_ARGS(link_status) \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 0), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 1), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 2), \ + _TRAIN_REQ_PREEMPH_ARGS(link_status, 3) total: 2 errors, 1 warnings, 2 checks, 41 lines checked 189e1f80ff45 drm/i915: Pimp link training debug prints 2581f8d15990 drm/i915: Call intel_dp_dump_link_status() for CR failures
