== Series Details == Series: Begin enabling Xe_HP SDV and DG2 platforms (rev6) URL : https://patchwork.freedesktop.org/series/92135/ State : warning == Summary == $ dim checkpatch origin/drm-tip f90c0193e566 drm/i915/xehpsdv: Correct parameters for IS_XEHPSDV_GT_STEP() -:24: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #24: FILE: drivers/gpu/drm/i915/i915_drv.h:1565: +#define IS_XEHPSDV_GT_STEP(__i915, since, until) \ + (IS_XEHPSDV(__i915) && IS_GT_STEP(__i915, since, until)) total: 0 errors, 0 warnings, 1 checks, 10 lines checked 42a1f6157116 drm/i915/xehp: Extra media engines - Part 1 (engine definitions) 3f65d319057d drm/i915/xehp: Extra media engines - Part 2 (interrupts) 25bc3daa002b drm/i915/xehp: Extra media engines - Part 3 (reset) 2b3f9bef9095 drm/i915/xehp: Xe_HP forcewake support -:10: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by: #10: Co-authored-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> -:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #26: FILE: drivers/gpu/drm/i915/gt/intel_execlists_submission.c:3362: + engine->fw_domain = intel_uncore_forcewake_for_reg(engine->uncore, + RING_EXECLIST_CONTROL(engine->mmio_base), -:209: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #209: FILE: drivers/gpu/drm/i915/intel_uncore.c:1323: + GEN_FW_RANGE(0x0, 0x1fff, 0), /* + 0x0 - 0xaff: reserved -:210: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #210: FILE: drivers/gpu/drm/i915/intel_uncore.c:1324: + 0xb00 - 0x1fff: always on */ -:214: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #214: FILE: drivers/gpu/drm/i915/intel_uncore.c:1328: + GEN_FW_RANGE(0x4b00, 0x51ff, 0), /* + 0x4b00 - 0x4fff: reserved -:215: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #215: FILE: drivers/gpu/drm/i915/intel_uncore.c:1329: + 0x5000 - 0x51ff: always on */ -:220: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #220: FILE: drivers/gpu/drm/i915/intel_uncore.c:1334: + GEN_FW_RANGE(0x8160, 0x81ff, 0), /* + 0x8160 - 0x817f: reserved -:221: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #221: FILE: drivers/gpu/drm/i915/intel_uncore.c:1335: + 0x8180 - 0x81ff: always on */ -:225: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #225: FILE: drivers/gpu/drm/i915/intel_uncore.c:1339: + GEN_FW_RANGE(0x8500, 0x94cf, FORCEWAKE_GT), /* + 0x8500 - 0x87ff: gt -:228: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #228: FILE: drivers/gpu/drm/i915/intel_uncore.c:1342: + 0x9480 - 0x94cf: reserved */ -:231: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #231: FILE: drivers/gpu/drm/i915/intel_uncore.c:1345: + GEN_FW_RANGE(0x9560, 0x97ff, 0), /* + 0x9560 - 0x95ff: always on -:232: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #232: FILE: drivers/gpu/drm/i915/intel_uncore.c:1346: + 0x9600 - 0x97ff: reserved */ -:234: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #234: FILE: drivers/gpu/drm/i915/intel_uncore.c:1348: + GEN_FW_RANGE(0x9800, 0xcfff, FORCEWAKE_GT), /* + 0x9800 - 0xb4ff: gt -:236: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #236: FILE: drivers/gpu/drm/i915/intel_uncore.c:1350: + 0xc000 - 0xcfff: gt */ -:241: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #241: FILE: drivers/gpu/drm/i915/intel_uncore.c:1355: + GEN_FW_RANGE(0xdd00, 0xde7f, FORCEWAKE_GT), /* + 0xdd00 - 0xddff: gt -:242: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #242: FILE: drivers/gpu/drm/i915/intel_uncore.c:1356: + 0xde00 - 0xde7f: reserved */ -:244: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #244: FILE: drivers/gpu/drm/i915/intel_uncore.c:1358: + GEN_FW_RANGE(0xde80, 0xe8ff, FORCEWAKE_RENDER), /* + 0xde80 - 0xdfff: render -:246: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #246: FILE: drivers/gpu/drm/i915/intel_uncore.c:1360: + 0xe100 - 0xe8ff: render */ -:248: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #248: FILE: drivers/gpu/drm/i915/intel_uncore.c:1362: + GEN_FW_RANGE(0xe900, 0xffff, FORCEWAKE_GT), /* + 0xe900 - 0xe9ff: gt -:250: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #250: FILE: drivers/gpu/drm/i915/intel_uncore.c:1364: + 0xf000 - 0xffff: gt */ -:252: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #252: FILE: drivers/gpu/drm/i915/intel_uncore.c:1366: + GEN_FW_RANGE(0x10000, 0x13fff, 0), /* + 0x10000 - 0x11fff: reserved -:254: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #254: FILE: drivers/gpu/drm/i915/intel_uncore.c:1368: + 0x12800 - 0x13fff: reserved */ -:260: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #260: FILE: drivers/gpu/drm/i915/intel_uncore.c:1374: + GEN_FW_RANGE(0x14800, 0x1ffff, FORCEWAKE_RENDER), /* + 0x14800 - 0x14fff: render -:262: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #262: FILE: drivers/gpu/drm/i915/intel_uncore.c:1376: + 0x16e00 - 0x1ffff: render */ -:264: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #264: FILE: drivers/gpu/drm/i915/intel_uncore.c:1378: + GEN_FW_RANGE(0x20000, 0x21fff, FORCEWAKE_MEDIA_VDBOX0), /* + 0x20000 - 0x20fff: VD0 -:265: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #265: FILE: drivers/gpu/drm/i915/intel_uncore.c:1379: + 0x21000 - 0x21fff: reserved */ -:268: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #268: FILE: drivers/gpu/drm/i915/intel_uncore.c:1382: + GEN_FW_RANGE(0x24000, 0x2417f, 0), /* + 0x24000 - 0x2407f: always on -:269: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #269: FILE: drivers/gpu/drm/i915/intel_uncore.c:1383: + 0x24080 - 0x2417f: reserved */ -:271: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #271: FILE: drivers/gpu/drm/i915/intel_uncore.c:1385: + GEN_FW_RANGE(0x24180, 0x249ff, FORCEWAKE_GT), /* + 0x24180 - 0x241ff: gt -:272: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #272: FILE: drivers/gpu/drm/i915/intel_uncore.c:1386: + 0x24200 - 0x249ff: reserved */ -:274: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #274: FILE: drivers/gpu/drm/i915/intel_uncore.c:1388: + GEN_FW_RANGE(0x24a00, 0x251ff, FORCEWAKE_RENDER), /* + 0x24a00 - 0x24a7f: render -:275: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #275: FILE: drivers/gpu/drm/i915/intel_uncore.c:1389: + 0x24a80 - 0x251ff: reserved */ -:277: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #277: FILE: drivers/gpu/drm/i915/intel_uncore.c:1391: + GEN_FW_RANGE(0x25200, 0x25fff, FORCEWAKE_GT), /* + 0x25200 - 0x252ff: gt -:278: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #278: FILE: drivers/gpu/drm/i915/intel_uncore.c:1392: + 0x25300 - 0x25fff: reserved */ -:280: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #280: FILE: drivers/gpu/drm/i915/intel_uncore.c:1394: + GEN_FW_RANGE(0x26000, 0x2ffff, FORCEWAKE_RENDER), /* + 0x26000 - 0x27fff: render -:282: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #282: FILE: drivers/gpu/drm/i915/intel_uncore.c:1396: + 0x2a000 - 0x2ffff: undocumented */ -:286: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #286: FILE: drivers/gpu/drm/i915/intel_uncore.c:1400: + GEN_FW_RANGE(0x1c0000, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0), /* + 0x1c0000 - 0x1c2bff: VD0 -:290: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #290: FILE: drivers/gpu/drm/i915/intel_uncore.c:1404: + 0x1c3f00 - 0x1c3fff: VD0 */ -:292: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #292: FILE: drivers/gpu/drm/i915/intel_uncore.c:1406: + GEN_FW_RANGE(0x1c4000, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1), /* + 0x1c4000 - 0x1c6bff: VD1 -:295: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #295: FILE: drivers/gpu/drm/i915/intel_uncore.c:1409: + 0x1c6e00 - 0x1c7fff: reserved */ -:297: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #297: FILE: drivers/gpu/drm/i915/intel_uncore.c:1411: + GEN_FW_RANGE(0x1c8000, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0), /* + 0x1c8000 - 0x1ca0ff: VE0 -:298: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #298: FILE: drivers/gpu/drm/i915/intel_uncore.c:1412: + 0x1ca100 - 0x1cbfff: reserved */ -:304: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #304: FILE: drivers/gpu/drm/i915/intel_uncore.c:1418: + GEN_FW_RANGE(0x1d0000, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2), /* + 0x1d0000 - 0x1d2bff: VD2 -:308: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #308: FILE: drivers/gpu/drm/i915/intel_uncore.c:1422: + 0x1d3f00 - 0x1d3fff: VD2 */ -:310: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #310: FILE: drivers/gpu/drm/i915/intel_uncore.c:1424: + GEN_FW_RANGE(0x1d4000, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3), /* + 0x1d4000 - 0x1d6bff: VD3 -:313: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #313: FILE: drivers/gpu/drm/i915/intel_uncore.c:1427: + 0x1d6e00 - 0x1d7fff: reserved */ -:315: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #315: FILE: drivers/gpu/drm/i915/intel_uncore.c:1429: + GEN_FW_RANGE(0x1d8000, 0x1dffff, FORCEWAKE_MEDIA_VEBOX1), /* + 0x1d8000 - 0x1da0ff: VE1 -:316: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #316: FILE: drivers/gpu/drm/i915/intel_uncore.c:1430: + 0x1da100 - 0x1dffff: reserved */ -:318: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #318: FILE: drivers/gpu/drm/i915/intel_uncore.c:1432: + GEN_FW_RANGE(0x1e0000, 0x1e3fff, FORCEWAKE_MEDIA_VDBOX4), /* + 0x1e0000 - 0x1e2bff: VD4 -:322: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #322: FILE: drivers/gpu/drm/i915/intel_uncore.c:1436: + 0x1e3f00 - 0x1e3fff: VD4 */ -:324: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #324: FILE: drivers/gpu/drm/i915/intel_uncore.c:1438: + GEN_FW_RANGE(0x1e4000, 0x1e7fff, FORCEWAKE_MEDIA_VDBOX5), /* + 0x1e4000 - 0x1e6bff: VD5 -:327: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #327: FILE: drivers/gpu/drm/i915/intel_uncore.c:1441: + 0x1e6e00 - 0x1e7fff: reserved */ -:329: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #329: FILE: drivers/gpu/drm/i915/intel_uncore.c:1443: + GEN_FW_RANGE(0x1e8000, 0x1effff, FORCEWAKE_MEDIA_VEBOX2), /* + 0x1e8000 - 0x1ea0ff: VE2 -:330: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #330: FILE: drivers/gpu/drm/i915/intel_uncore.c:1444: + 0x1ea100 - 0x1effff: reserved */ -:332: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #332: FILE: drivers/gpu/drm/i915/intel_uncore.c:1446: + GEN_FW_RANGE(0x1f0000, 0x1f3fff, FORCEWAKE_MEDIA_VDBOX6), /* + 0x1f0000 - 0x1f2bff: VD6 -:336: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #336: FILE: drivers/gpu/drm/i915/intel_uncore.c:1450: + 0x1f3f00 - 0x1f3fff: VD6 */ -:338: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #338: FILE: drivers/gpu/drm/i915/intel_uncore.c:1452: + GEN_FW_RANGE(0x1f4000, 0x1f7fff, FORCEWAKE_MEDIA_VDBOX7), /* + 0x1f4000 - 0x1f6bff: VD7 -:341: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #341: FILE: drivers/gpu/drm/i915/intel_uncore.c:1455: + 0x1f6e00 - 0x1f7fff: reserved */ total: 0 errors, 57 warnings, 1 checks, 467 lines checked 70b1a7998cf4 drm/i915/xehp: handle new steering options -:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #51: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:117: + if (GRAPHICS_VER(gt->i915) >= 11 && + GRAPHICS_VER_FULL(gt->i915) < IP_VER(12, 50)) { -:195: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #195: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:892: + unsigned slice, unsigned subslice) -:195: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #195: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:892: + unsigned slice, unsigned subslice) total: 0 errors, 2 warnings, 1 checks, 282 lines checked 21933a40845a drm/i915/xehp: Loop over all gslices for INSTDONE processing -:135: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter_' - possible side-effects? #135: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:579: +#define for_each_instdone_gslice_dss_xehp(dev_priv_, sseu_, iter_, gslice_, dss_) \ + for ((iter_) = 0, (gslice_) = 0, (dss_) = 0; \ + (iter_) < GEN_MAX_SUBSLICES; \ + (iter_)++, (gslice_) = (iter_) / GEN_DSS_PER_GSLICE, \ + (dss_) = (iter_) % GEN_DSS_PER_GSLICE) \ + for_each_if(intel_sseu_has_subslice((sseu_), 0, (iter_))) -:135: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gslice_' - possible side-effects? #135: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:579: +#define for_each_instdone_gslice_dss_xehp(dev_priv_, sseu_, iter_, gslice_, dss_) \ + for ((iter_) = 0, (gslice_) = 0, (dss_) = 0; \ + (iter_) < GEN_MAX_SUBSLICES; \ + (iter_)++, (gslice_) = (iter_) / GEN_DSS_PER_GSLICE, \ + (dss_) = (iter_) % GEN_DSS_PER_GSLICE) \ + for_each_if(intel_sseu_has_subslice((sseu_), 0, (iter_))) -:135: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dss_' - possible side-effects? #135: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:579: +#define for_each_instdone_gslice_dss_xehp(dev_priv_, sseu_, iter_, gslice_, dss_) \ + for ((iter_) = 0, (gslice_) = 0, (dss_) = 0; \ + (iter_) < GEN_MAX_SUBSLICES; \ + (iter_)++, (gslice_) = (iter_) / GEN_DSS_PER_GSLICE, \ + (dss_) = (iter_) % GEN_DSS_PER_GSLICE) \ + for_each_if(intel_sseu_has_subslice((sseu_), 0, (iter_))) total: 0 errors, 0 warnings, 3 checks, 164 lines checked 456e57370fcd drm/i915/xehp: Changes to ss/eu definitions 94a690b2b730 drm/i915/xehpsdv: Add maximum sseu limits 278d359e56da drm/i915/xehpsdv: Add compute DSS type 0a73f890d107 drm/i915/xehpsdv: Define steering tables 3def48fb4238 drm/i915/xehpsdv: Define MOCS table for XeHP SDV 83b0be478cb4 drm/i915/xehpsdv: factor out function to read RP_STATE_CAP da9489e90eda drm/i915/xehpsdv: Read correct RP_STATE_CAP register 4057f5104c28 drm/i915/dg2: DG2 uses the same sseu limits as XeHP SDV 1ace9a8d1b2a drm/i915/dg2: Add forcewake table -:178: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #178: FILE: drivers/gpu/drm/i915/intel_uncore.c:1328: + GEN_FW_RANGE(0x0, 0x1fff, 0), /* \ + 0x0 - 0xaff: reserved \ -:179: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #179: FILE: drivers/gpu/drm/i915/intel_uncore.c:1329: + 0xb00 - 0x1fff: always on */ \ -:183: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #183: FILE: drivers/gpu/drm/i915/intel_uncore.c:1333: + GEN_FW_RANGE(0x4b00, 0x51ff, 0), /* \ + 0x4b00 - 0x4fff: reserved \ -:184: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #184: FILE: drivers/gpu/drm/i915/intel_uncore.c:1334: + 0x5000 - 0x51ff: always on */ \ -:189: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #189: FILE: drivers/gpu/drm/i915/intel_uncore.c:1339: + GEN_FW_RANGE(0x8160, 0x81ff, 0), /* \ + 0x8160 - 0x817f: reserved \ -:190: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #190: FILE: drivers/gpu/drm/i915/intel_uncore.c:1340: + 0x8180 - 0x81ff: always on */ \ -:194: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #194: FILE: drivers/gpu/drm/i915/intel_uncore.c:1344: + GEN_FW_RANGE(0x8500, 0x8cff, FORCEWAKE_GT), /* \ + 0x8500 - 0x87ff: gt \ -:196: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #196: FILE: drivers/gpu/drm/i915/intel_uncore.c:1346: + 0x8c80 - 0x8cff: gt (DG2 only) */ \ -:198: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #198: FILE: drivers/gpu/drm/i915/intel_uncore.c:1348: + GEN_FW_RANGE(0x8d00, 0x8fff, FORCEWAKE_RENDER), /* \ + 0x8d00 - 0x8dff: render (DG2 only) \ -:199: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #199: FILE: drivers/gpu/drm/i915/intel_uncore.c:1349: + 0x8e00 - 0x8fff: reserved */ \ -:201: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #201: FILE: drivers/gpu/drm/i915/intel_uncore.c:1351: + GEN_FW_RANGE(0x9000, 0x94cf, FORCEWAKE_GT), /* \ + 0x9000 - 0x947f: gt \ -:202: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #202: FILE: drivers/gpu/drm/i915/intel_uncore.c:1352: + 0x9480 - 0x94cf: reserved */ \ -:205: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #205: FILE: drivers/gpu/drm/i915/intel_uncore.c:1355: + GEN_FW_RANGE(0x9560, 0x967f, 0), /* \ + 0x9560 - 0x95ff: always on \ -:206: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #206: FILE: drivers/gpu/drm/i915/intel_uncore.c:1356: + 0x9600 - 0x967f: reserved */ \ -:208: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #208: FILE: drivers/gpu/drm/i915/intel_uncore.c:1358: + GEN_FW_RANGE(0x9680, 0x97ff, FORCEWAKE_RENDER), /* \ + 0x9680 - 0x96ff: render (DG2 only) \ -:209: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #209: FILE: drivers/gpu/drm/i915/intel_uncore.c:1359: + 0x9700 - 0x97ff: reserved */ \ -:211: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #211: FILE: drivers/gpu/drm/i915/intel_uncore.c:1361: + GEN_FW_RANGE(0x9800, 0xcfff, FORCEWAKE_GT), /* \ + 0x9800 - 0xb4ff: gt \ -:213: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #213: FILE: drivers/gpu/drm/i915/intel_uncore.c:1363: + 0xc000 - 0xcfff: gt */ \ -:219: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #219: FILE: drivers/gpu/drm/i915/intel_uncore.c:1369: + GEN_FW_RANGE(0xdd00, 0xde7f, FORCEWAKE_GT), /* \ + 0xdd00 - 0xddff: gt \ -:220: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #220: FILE: drivers/gpu/drm/i915/intel_uncore.c:1370: + 0xde00 - 0xde7f: reserved */ \ -:222: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #222: FILE: drivers/gpu/drm/i915/intel_uncore.c:1372: + GEN_FW_RANGE(0xde80, 0xe8ff, FORCEWAKE_RENDER), /* \ + 0xde80 - 0xdfff: render \ -:224: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #224: FILE: drivers/gpu/drm/i915/intel_uncore.c:1374: + 0xe100 - 0xe8ff: render */ \ -:226: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #226: FILE: drivers/gpu/drm/i915/intel_uncore.c:1376: + GEN_FW_RANGE(0xe900, 0xffff, FORCEWAKE_GT), /* \ + 0xe900 - 0xe9ff: gt \ -:228: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #228: FILE: drivers/gpu/drm/i915/intel_uncore.c:1378: + 0xf000 - 0xffff: gt */ \ -:230: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #230: FILE: drivers/gpu/drm/i915/intel_uncore.c:1380: + GEN_FW_RANGE(0x10000, 0x12fff, 0), /* \ + 0x10000 - 0x11fff: reserved \ -:232: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #232: FILE: drivers/gpu/drm/i915/intel_uncore.c:1382: + 0x12800 - 0x12fff: reserved */ \ -:235: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #235: FILE: drivers/gpu/drm/i915/intel_uncore.c:1385: + GEN_FW_RANGE(0x13200, 0x13fff, FORCEWAKE_MEDIA_VDBOX2), /* \ + 0x13200 - 0x133ff: VD2 (DG2 only) \ -:236: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #236: FILE: drivers/gpu/drm/i915/intel_uncore.c:1386: + 0x13400 - 0x13fff: reserved */ \ -:243: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #243: FILE: drivers/gpu/drm/i915/intel_uncore.c:1393: + GEN_FW_RANGE(0x15000, 0x16dff, FORCEWAKE_GT), /* \ + 0x15000 - 0x15fff: gt (DG2 only) \ -:244: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #244: FILE: drivers/gpu/drm/i915/intel_uncore.c:1394: + 0x16000 - 0x16dff: reserved */ \ -:247: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #247: FILE: drivers/gpu/drm/i915/intel_uncore.c:1397: + GEN_FW_RANGE(0x20000, 0x21fff, FORCEWAKE_MEDIA_VDBOX0), /* \ + 0x20000 - 0x20fff: VD0 (XEHPSDV only) \ -:248: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #248: FILE: drivers/gpu/drm/i915/intel_uncore.c:1398: + 0x21000 - 0x21fff: reserved */ \ -:251: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #251: FILE: drivers/gpu/drm/i915/intel_uncore.c:1401: + GEN_FW_RANGE(0x24000, 0x2417f, 0), /* \ + 0x24000 - 0x2407f: always on \ -:252: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #252: FILE: drivers/gpu/drm/i915/intel_uncore.c:1402: + 0x24080 - 0x2417f: reserved */ \ -:254: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #254: FILE: drivers/gpu/drm/i915/intel_uncore.c:1404: + GEN_FW_RANGE(0x24180, 0x249ff, FORCEWAKE_GT), /* \ + 0x24180 - 0x241ff: gt \ -:255: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #255: FILE: drivers/gpu/drm/i915/intel_uncore.c:1405: + 0x24200 - 0x249ff: reserved */ \ -:257: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #257: FILE: drivers/gpu/drm/i915/intel_uncore.c:1407: + GEN_FW_RANGE(0x24a00, 0x251ff, FORCEWAKE_RENDER), /* \ + 0x24a00 - 0x24a7f: render \ -:258: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #258: FILE: drivers/gpu/drm/i915/intel_uncore.c:1408: + 0x24a80 - 0x251ff: reserved */ \ -:260: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #260: FILE: drivers/gpu/drm/i915/intel_uncore.c:1410: + GEN_FW_RANGE(0x25200, 0x25fff, FORCEWAKE_GT), /* \ + 0x25200 - 0x252ff: gt \ -:261: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #261: FILE: drivers/gpu/drm/i915/intel_uncore.c:1411: + 0x25300 - 0x25fff: reserved */ \ -:263: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #263: FILE: drivers/gpu/drm/i915/intel_uncore.c:1413: + GEN_FW_RANGE(0x26000, 0x2ffff, FORCEWAKE_RENDER), /* \ + 0x26000 - 0x27fff: render \ -:265: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #265: FILE: drivers/gpu/drm/i915/intel_uncore.c:1415: + 0x2a000 - 0x2ffff: undocumented */ \ -:269: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #269: FILE: drivers/gpu/drm/i915/intel_uncore.c:1419: + GEN_FW_RANGE(0x1c0000, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0), /* \ + 0x1c0000 - 0x1c2bff: VD0 \ -:273: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #273: FILE: drivers/gpu/drm/i915/intel_uncore.c:1423: + 0x1c3f00 - 0x1c3fff: VD0 */ \ -:275: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #275: FILE: drivers/gpu/drm/i915/intel_uncore.c:1425: + GEN_FW_RANGE(0x1c4000, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1), /* \ + 0x1c4000 - 0x1c6bff: VD1 \ -:278: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #278: FILE: drivers/gpu/drm/i915/intel_uncore.c:1428: + 0x1c6e00 - 0x1c7fff: reserved */ \ -:280: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #280: FILE: drivers/gpu/drm/i915/intel_uncore.c:1430: + GEN_FW_RANGE(0x1c8000, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0), /* \ + 0x1c8000 - 0x1ca0ff: VE0 \ -:281: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #281: FILE: drivers/gpu/drm/i915/intel_uncore.c:1431: + 0x1ca100 - 0x1cbfff: reserved */ \ -:287: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #287: FILE: drivers/gpu/drm/i915/intel_uncore.c:1437: + GEN_FW_RANGE(0x1d0000, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2), /* \ + 0x1d0000 - 0x1d2bff: VD2 \ -:292: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #292: FILE: drivers/gpu/drm/i915/intel_uncore.c:1442: + 0x1d3f00 - 0x1d3fff: VD2 */ \ -:294: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #294: FILE: drivers/gpu/drm/i915/intel_uncore.c:1444: + GEN_FW_RANGE(0x1d4000, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3), /* \ + 0x1d4000 - 0x1d6bff: VD3 \ -:297: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #297: FILE: drivers/gpu/drm/i915/intel_uncore.c:1447: + 0x1d6e00 - 0x1d7fff: reserved */ \ -:299: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #299: FILE: drivers/gpu/drm/i915/intel_uncore.c:1449: + GEN_FW_RANGE(0x1d8000, 0x1dffff, FORCEWAKE_MEDIA_VEBOX1), /* \ + 0x1d8000 - 0x1da0ff: VE1 \ -:300: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #300: FILE: drivers/gpu/drm/i915/intel_uncore.c:1450: + 0x1da100 - 0x1dffff: reserved */ \ -:302: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #302: FILE: drivers/gpu/drm/i915/intel_uncore.c:1452: + GEN_FW_RANGE(0x1e0000, 0x1e3fff, FORCEWAKE_MEDIA_VDBOX4), /* \ + 0x1e0000 - 0x1e2bff: VD4 \ -:306: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #306: FILE: drivers/gpu/drm/i915/intel_uncore.c:1456: + 0x1e3f00 - 0x1e3fff: VD4 */ \ -:308: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #308: FILE: drivers/gpu/drm/i915/intel_uncore.c:1458: + GEN_FW_RANGE(0x1e4000, 0x1e7fff, FORCEWAKE_MEDIA_VDBOX5), /* \ + 0x1e4000 - 0x1e6bff: VD5 \ -:311: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #311: FILE: drivers/gpu/drm/i915/intel_uncore.c:1461: + 0x1e6e00 - 0x1e7fff: reserved */ \ -:313: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #313: FILE: drivers/gpu/drm/i915/intel_uncore.c:1463: + GEN_FW_RANGE(0x1e8000, 0x1effff, FORCEWAKE_MEDIA_VEBOX2), /* \ + 0x1e8000 - 0x1ea0ff: VE2 \ -:314: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #314: FILE: drivers/gpu/drm/i915/intel_uncore.c:1464: + 0x1ea100 - 0x1effff: reserved */ \ -:316: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #316: FILE: drivers/gpu/drm/i915/intel_uncore.c:1466: + GEN_FW_RANGE(0x1f0000, 0x1f3fff, FORCEWAKE_MEDIA_VDBOX6), /* \ + 0x1f0000 - 0x1f2bff: VD6 \ -:320: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #320: FILE: drivers/gpu/drm/i915/intel_uncore.c:1470: + 0x1f3f00 - 0x1f3fff: VD6 */ \ -:322: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #322: FILE: drivers/gpu/drm/i915/intel_uncore.c:1472: + GEN_FW_RANGE(0x1f4000, 0x1f7fff, FORCEWAKE_MEDIA_VDBOX7), /* \ + 0x1f4000 - 0x1f6bff: VD7 \ -:325: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #325: FILE: drivers/gpu/drm/i915/intel_uncore.c:1475: + 0x1f6e00 - 0x1f7fff: reserved */ \ total: 0 errors, 64 warnings, 0 checks, 318 lines checked 134cfcfd9c84 drm/i915/dg2: Update LNCF steering ranges f7b8d3a066bf drm/i915/dg2: Add SQIDI steering e1706eba9559 drm/i915/dg2: Add new LRI reg offsets 9542a06a5a35 drm/i915/dg2: Maintain backward-compatible nested batch behavior 6a189a7ddf4d drm/i915/dg2: Report INSTDONE_GEOM values in error state a4f5ef996270 drm/i915/dg2: Define MOCS table for DG2 2f1319f28f47 drm/i915/dg2: Add MPLLB programming for SNPS PHY -:110: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #110: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 671 lines checked ba80b83c84a9 drm/i915/dg2: Add MPLLB programming for HDMI -:33: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #33: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:3750: +static void dg2_ddi_get_config(struct intel_encoder *encoder, + struct intel_crtc_state *crtc_state) -:82: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects? #82: FILE: drivers/gpu/drm/i915/display/intel_display.c:9163: +#define MPLLB_CHECK(name) do { \ + if (mpllb_sw_state->name != mpllb_hw_state.name) { \ + pipe_config_mismatch(false, crtc, "MPLLB:" __stringify(name), \ + "(expected 0x%08x, found 0x%08x)", \ + mpllb_sw_state->name, \ + mpllb_hw_state.name); \ + } \ +} while (0) -:82: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #82: FILE: drivers/gpu/drm/i915/display/intel_display.c:9163: +#define MPLLB_CHECK(name) do { \ + if (mpllb_sw_state->name != mpllb_hw_state.name) { \ + pipe_config_mismatch(false, crtc, "MPLLB:" __stringify(name), \ + "(expected 0x%08x, found 0x%08x)", \ + mpllb_sw_state->name, \ + mpllb_hw_state.name); \ + } \ +} while (0) total: 0 errors, 0 warnings, 3 checks, 459 lines checked b1efd88312b8 drm/i915/dg2: Add vswing programming for SNPS phys c17b50b62625 drm/i915/dg2: Update modeset sequences e45963bba93a drm/i915/dg2: Wait for SNPS PHY calibration during display init aa3166a1e277 drm/i915/dg2: Update lane disable power state during PSR 76199f2888ef drm/i915/dg2: Update to bigjoiner path bcdeb7e1edf0 drm/i915/dg2: Configure PCON in DP pre-enable path _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
