On Tue, Apr 23, 2013 at 10:39:35PM +0200, Daniel Vetter wrote: > On Tue, Apr 23, 2013 at 06:27:54PM +0300, Ville Syrj?l? wrote: > > The g4x docs are a bit confusing though. They seem to indicate the the > > PIPECONF dither controls only affect DP. > > Hm, this could put a pending question from Jesse at ease whether we should > still enable dithering in the lvds port register on g4x. Can you point me > at the relevant bspec language? I didn't spot anything when hunting around > in the docs ... Hm, I've done some testing and the pipeconf dithering seems to indeed have no effect on the lvds panel. I've gotten away since this patch didn't clear that bit correctly. I'll update the patch. If you can dig out the Bspec reference, that'd still be great. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch