On Fri, 19 Apr 2013 11:24:37 +0200 Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > + pipeconf &= ~(PIPECONF_BPC_MASK | PIPECONF_DITHER_EN); > + if (intel_crtc->config.dither && intel_crtc->config.pipe_bpp != 30) I think the magic != 30 check needs a comment, or we should never set .dither for 30bpp modes in the various compute_configs. -- Jesse Barnes, Intel Open Source Technology Center
