On Tue, Apr 20, 2021 at 03:57:45PM +0300, Jani Nikula wrote: > On Fri, 16 Apr 2021, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > A bunch of drive-by-cleanup While I was reading through > > the dbuf code. > > Good stuff. On the series, > > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Some thoughts provoked by the series: > > * Time to start splitting up dbuf/ddb/wm stuff from intel_pm.[ch] to > separate file(s) under display/? I guess we could start shoveling. I've been putting it off due to having bunch of in-flight stuff (wm latency cleanups, s/intel/ilk/ rename, and some wip skl+ dbuf patches come to mind). But I suppose those aren't going to make any progress without a reposting anyway. I could always respin them after the code has settled in its new home. > > * Time to start moving more display related struct intel_device_info > fields under the display substruct? Perhaps. I was a bit torn between .dbuf and .display.dbuf for this series. In the end I decided that .display.dbuf is a bit too long for my liking. Not sure if s/.display/.de/ might make it more palatable... -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
