Re: [PATCH 0/8] drm/i915: dbuf cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 16 Apr 2021, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> A bunch of drive-by-cleanup While I was reading through
> the dbuf code.

Good stuff. On the series,

Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Some thoughts provoked by the series:

* Time to start splitting up dbuf/ddb/wm stuff from intel_pm.[ch] to
  separate file(s) under display/?

* Time to start moving more display related struct intel_device_info
  fields under the display substruct?

BR,
Jani.


>
> Ville Syrjälä (8):
>   drm/i915: Collect dbuf device info into a sub-struct
>   drm/i915: Handle dbuf bypass path allocation earlier
>   drm/i915: Store dbuf slice mask in device info
>   drm/i915: Use intel_dbuf_slice_size()
>   drm/i915: Use intel_de_rmw() for DBUF_POWER_REQUEST
>   drm/i915: Polish for_each_dbuf_slice()
>   drm/i915: Add enabledisable()
>   drm/i915: Say "enable foo" instead of "set foo to enabled"
>
>  drivers/gpu/drm/i915/display/intel_bw.c       | 11 ++---
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  4 +-
>  drivers/gpu/drm/i915/display/intel_display.h  |  9 ++--
>  .../drm/i915/display/intel_display_power.c    | 24 ++++------
>  drivers/gpu/drm/i915/display/intel_dp.c       | 14 +++---
>  .../drm/i915/display/intel_dp_aux_backlight.c |  2 +-
>  drivers/gpu/drm/i915/display/intel_tc.c       |  4 +-
>  drivers/gpu/drm/i915/i915_pci.c               | 16 +++----
>  drivers/gpu/drm/i915/i915_utils.h             |  5 +++
>  drivers/gpu/drm/i915/intel_device_info.h      |  6 ++-
>  drivers/gpu/drm/i915/intel_pm.c               | 45 +++++++------------
>  drivers/gpu/drm/i915/intel_pm.h               |  1 +
>  12 files changed, 65 insertions(+), 76 deletions(-)

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux