== Series Details == Series: drm/i915: Add support for FBs requiring a POT stride padding (rev3) URL : https://patchwork.freedesktop.org/series/87859/ State : warning == Summary == $ dim checkpatch origin/drm-tip 09b57964ee1a drm/i915: Fix rotation setup during plane HW readout 1add1c1e3590 drm/i915/selftest: Fix error handling in igt_vma_remapped_gtt() c8f8f224a2f4 drm/i915/selftest: Fix debug message in igt_vma_remapped_gtt() d69907b34f92 drm/i915: Make sure i915_ggtt_view is inited when creating an FB 432c34011eb7 drm/i915/selftest: Make sure to init i915_ggtt_view in igt_vma_rotate_remap() d36175b1b932 drm/i915/intel_fb: Pull FB plane functions from intel_display_types.h -:78: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 95 lines checked 0d7a1a670b95 drm/i915/intel_fb: Pull FB plane functions from skl_universal_plane.c c6464f4378de drm/i915/intel_fb: Pull is_surface_linear() from intel_display.c/skl_universal_plane.c 397e72df537f drm/i915/intel_fb: Pull FB plane functions from intel_sprite.c f0cc6bc131c9 drm/i915/intel_fb: Pull FB plane functions from intel_display.c -:1341: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1341: FILE: drivers/gpu/drm/i915/display/intel_fb.c:435: + drm_dbg_kms(&i915->drm, + "Bad CCS x/y (main %d,%d ccs %d,%d) full (main %d,%d ccs %d,%d)\n", total: 0 errors, 0 warnings, 1 checks, 1780 lines checked b8f83dc1f235 drm/i915/intel_fb: Unexport intel_fb_check_stride() 12cb02ede602 drm/i915/intel_fb: s/dev_priv/i915/ 848242f45a3f drm/i915/intel_fb: Factor out convert_plane_offset_to_xy() -:67: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #67: FILE: drivers/gpu/drm/i915/display/intel_fb.c:551: + (*x + plane_width) * fb->base.format->cpp[color_plane] > fb->base.pitches[color_plane]) { total: 0 errors, 1 warnings, 0 checks, 92 lines checked 8e9ea612941d drm/i915/intel_fb: Factor out calc_plane_aligned_offset() -:25: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #25: FILE: drivers/gpu/drm/i915/display/intel_fb.c:561: +static u32 calc_plane_aligned_offset(const struct intel_framebuffer *fb, int color_plane, int *x, int *y) total: 0 errors, 1 warnings, 0 checks, 43 lines checked 2ba06d265715 drm/i915/intel_fb: Factor out calc_plane_normal_size() -:22: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #22: - Add back the +1 tile adjustment for x!=0 in calc_plane_normal_size(). (Ville) total: 0 errors, 1 warnings, 0 checks, 132 lines checked 9b0815c4a082 drm/i915: Unify the FB and plane state view information into one struct cf97dd091bb2 drm/i915: Store the normal view FB pitch in FB's intel_fb_view -:11: WARNING:TYPO_SPELLING: 'retrive' may be misspelled - perhaps 'retrieve'? #11: it during FB creation to the FB normal view struct and retrive it from ^^^^^^^ total: 0 errors, 1 warnings, 0 checks, 24 lines checked dc4b4a551b93 drm/i915: Simplify copying the FB view state to the plane state -:66: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #66: FILE: drivers/gpu/drm/i915/display/intel_fb.c:487: +static int intel_fb_pitch(const struct intel_framebuffer *fb, int color_plane, unsigned int rotation) total: 0 errors, 1 warnings, 0 checks, 182 lines checked 0435822005cc drm/i915/intel_fb: Factor out calc_plane_remap_info() -:198: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #198: FILE: drivers/gpu/drm/i915/display/intel_fb.c:769: + offset, gtt_offset_rotated, x, y, total: 0 errors, 1 warnings, 0 checks, 256 lines checked 04760a228df9 drm/i915: Shrink the size of intel_remapped_plane_info struct -:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects? #29: FILE: drivers/gpu/drm/i915/display/intel_fb.c:616: +#define assign_chk_ovf(i915, var, val) ({ \ + drm_WARN_ON(&(i915)->drm, overflows_type(val, var)); \ + var = val; \ +}) -:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects? #29: FILE: drivers/gpu/drm/i915/display/intel_fb.c:616: +#define assign_chk_ovf(i915, var, val) ({ \ + drm_WARN_ON(&(i915)->drm, overflows_type(val, var)); \ + var = val; \ +}) total: 0 errors, 0 warnings, 2 checks, 62 lines checked 93d0281c4ba3 drm/i915/selftest: Unify use of intel_remapped_plane_info in igt_vma_rotate_remap() -:61: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #61: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:549: + expected_pages = rotated_size(&plane_info[0], &plane_info[1]); total: 0 errors, 1 warnings, 0 checks, 124 lines checked 8d44da0209c1 drm/i915: s/stride/src_stride/ in the intel_remapped_plane_info struct -:37: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #37: FILE: drivers/gpu/drm/i915/display/intel_fb.c:636: + assign_chk_ovf(i915, remap_info->src_stride, plane_view_src_stride_tiles(fb, color_plane, dims)); total: 0 errors, 1 warnings, 0 checks, 181 lines checked 8b68c1f5e3ce drm/i915: Add support for FBs requiring a POT stride alignment -:194: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #194: FILE: drivers/gpu/drm/i915/display/intel_fb.c:807: + offset, gtt_offset_remapped, x, y, total: 0 errors, 1 warnings, 0 checks, 333 lines checked 81fb2f0a6835 drm/i915/selftest: Add remap/rotate vma subtests when dst_stride!=width/height -:112: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #112: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:536: { + -:137: WARNING:LONG_LINE: line length of 114 exceeds 100 columns #137: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:630: + expected_pages = remapped_size(view.type, &plane_info[0], &plane_info[1]); -:178: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #178: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:1018: + offset = (x * plane_info[0].dst_stride + y) * PAGE_SIZE; -:181: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #181: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:1020: + offset = (y * plane_info[0].dst_stride + x) * PAGE_SIZE; total: 0 errors, 3 warnings, 1 checks, 157 lines checked 589eb635f86d drm/i915: For-CI: Force remapping the FB with a POT aligned stride _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
