This is v2 of [1], addressing Ville's review comments. A bigger change is unifying the FB and plane view calculation more in patch 16-18. Besides these patch 15 also needs an r-b. v1 triggered a problem in igt/kms_busy, kms_cursor_legacy, which should be now fixed by [2]. [1] https://patchwork.freedesktop.org/series/87859/ [2] https://patchwork.freedesktop.org/series/88300/ Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Imre Deak (25): drm/i915: Fix rotation setup during plane HW readout drm/i915/selftest: Fix error handling in igt_vma_remapped_gtt() drm/i915/selftest: Fix debug message in igt_vma_remapped_gtt() drm/i915: Make sure i915_ggtt_view is inited when creating an FB drm/i915/selftest: Make sure to init i915_ggtt_view in igt_vma_rotate_remap() drm/i915/intel_fb: Pull FB plane functions from intel_display_types.h drm/i915/intel_fb: Pull FB plane functions from skl_universal_plane.c drm/i915/intel_fb: Pull is_surface_linear() from intel_display.c/skl_universal_plane.c drm/i915/intel_fb: Pull FB plane functions from intel_sprite.c drm/i915/intel_fb: Pull FB plane functions from intel_display.c drm/i915/intel_fb: Unexport intel_fb_check_stride() drm/i915/intel_fb: s/dev_priv/i915/ drm/i915/intel_fb: Factor out convert_plane_offset_to_xy() drm/i915/intel_fb: Factor out calc_plane_aligned_offset() drm/i915/intel_fb: Factor out calc_plane_normal_size() drm/i915: Unify the FB and plane state view information into one struct drm/i915: Store the normal view FB pitch in FB's intel_fb_view drm/i915: Simplify copying the FB view state to the plane state drm/i915/intel_fb: Factor out calc_plane_remap_info() drm/i915: Shrink the size of intel_remapped_plane_info struct drm/i915/selftest: Unify use of intel_remapped_plane_info in igt_vma_rotate_remap() drm/i915: s/stride/src_stride/ in the intel_remapped_plane_info struct drm/i915: Add support for FBs requiring a POT stride alignment drm/i915/selftest: Add remap/rotate vma subtests when dst_stride!=width/height drm/i915: For-CI: Force remapping the FB with a POT aligned stride drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/i9xx_plane.c | 21 +- drivers/gpu/drm/i915/display/intel_cursor.c | 15 +- drivers/gpu/drm/i915/display/intel_display.c | 861 +--------------- drivers/gpu/drm/i915/display/intel_display.h | 13 - .../drm/i915/display/intel_display_types.h | 81 +- drivers/gpu/drm/i915/display/intel_fb.c | 973 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_fb.h | 58 ++ drivers/gpu/drm/i915/display/intel_fbc.c | 6 +- drivers/gpu/drm/i915/display/intel_sprite.c | 58 +- drivers/gpu/drm/i915/display/intel_sprite.h | 1 - .../drm/i915/display/skl_universal_plane.c | 112 +- .../drm/i915/display/skl_universal_plane.h | 2 - drivers/gpu/drm/i915/gt/intel_ggtt.c | 58 +- drivers/gpu/drm/i915/i915_debugfs.c | 16 +- drivers/gpu/drm/i915/i915_vma_types.h | 12 +- drivers/gpu/drm/i915/selftests/i915_vma.c | 217 ++-- 17 files changed, 1382 insertions(+), 1123 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_fb.c create mode 100644 drivers/gpu/drm/i915/display/intel_fb.h -- 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx