Re: [PATCH i-g-t] intel_gpu_top: Hide unused clients

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 31/01/2021 03:11, Chris Wilson wrote:
Keep new clients hidden until they utilise the GPU.

Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
---
  tools/intel_gpu_top.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 60ff62d28..66a8effa6 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name)
  		c->last[i] = val[i];
  	}
- c->samples++;
+	if (!c->total_runtime)
+		return;
+
  	c->status = ALIVE;
+	c->samples++;
  }
static void


Not sure we need to do it at this level and not instead at presentation time. Plus, in default sort mode they would be at the end of the list, so behind the more active clients. Or you go into sort by id and they annoy you there?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux