Quoting Matthew Auld (2021-01-27 12:48:06) > static struct intel_memory_region *setup_lmem(struct intel_gt *gt) > { > struct drm_i915_private *i915 = gt->i915; > @@ -167,6 +202,16 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) > I915_GTT_PAGE_SIZE_4K, > io_start, > &intel_region_lmem_ops); > + if (!IS_ERR(mem)) { > + int err; > + > + err = reserve_lowmem_region(uncore, mem); > + if (err) { > + intel_memory_region_put(mem); > + return ERR_PTR(err); Just a worry here, are we likely to antagonise Joonas by having multiple error paths? -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx