Re: [PATCH 3/3] drm/i915/gt: Remove uninterruptible parameter from intel_gt_wait_for_idle

[Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>]

Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:

> Now that the only user of the uninterruptible wait was eliminated,
> remove the support.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/gt/intel_gt_requests.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_requests.c b/drivers/gpu/drm/i915/gt/intel_gt_requests.c
> index 66fcbf9d0fdd..dc06c78c9eeb 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_requests.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_requests.c
> @@ -135,13 +135,8 @@ long intel_gt_retire_requests_timeout(struct intel_gt *gt, long timeout)
>  	struct intel_gt_timelines *timelines = &gt->timelines;
>  	struct intel_timeline *tl, *tn;
>  	unsigned long active_count = 0;
> -	bool interruptible;
>  	LIST_HEAD(free);
>  
> -	interruptible = true;
> -	if (unlikely(timeout < 0))
> -		timeout = -timeout, interruptible = false;
> -
>  	flush_submission(gt, timeout); /* kick the ksoftirqd tasklets */
>  	spin_lock(&timelines->lock);
>  	list_for_each_entry_safe(tl, tn, &timelines->active_list, link) {
> @@ -163,7 +158,7 @@ long intel_gt_retire_requests_timeout(struct intel_gt *gt, long timeout)
>  				mutex_unlock(&tl->mutex);
>  
>  				timeout = dma_fence_wait_timeout(fence,
> -								 interruptible,
> +								 true,
>  								 timeout);
>  				dma_fence_put(fence);
>  
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx