On Mon, Feb 18, 2013 at 11:58:23AM +0200, Ville Syrj?l? wrote: > On Fri, Feb 15, 2013 at 11:53:14PM +0000, Chris Wilson wrote: > > On Fri, Feb 15, 2013 at 05:07:44PM +0200, ville.syrjala at linux.intel.com wrote: > > > From: Ville Syrj?l? <ville.syrjala at linux.intel.com> > > > > > > Someone may be waiting for a flip that will never complete due to a GPU > > > reset. Wake up all such waiters after the GPU reset processing has > > > finished. > > > > > > v2: Dropped the wake_up_all() from i915_handle_error() since > > > we no longer wait for pending flips with struct_mutex held. > > > > Isn't the wake_up(pending_flip_queue) superseded by performing the > > explicit do_intel_finish_page_flip() in patch 3? > > Yes that's correct. But I actually forgot to remove the wake_up patch > from my tree when I tested this. I'll run a few more tests just to make > sure it still works. I just tried it w/o the wake_up_all() and unfortunately it hung :( Need to think about it a bit more I suppose. -- Ville Syrj?l? Intel OTC
