[PATCH] drm/i915: Eliminate race from gen2/3 page flip interrupt handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 18, 2013 at 02:27:24PM +0200, Ville Syrj?l? wrote:
> On Mon, Feb 18, 2013 at 12:16:09PM +0000, Chris Wilson wrote:
> > /* We detect FlipDone by looking for the change in PendingFlip from '1'
> >  * to '0' on the following vblank, i.e. IIR has the Pendingflip
> >  * asserted following the MI_DISPLAY_FLIP, but ISR is deasserted, hence
> >  * the flip is completed (no longer pending). Since this doesn't raise an
> >  * interrupt per-se, we watch for the change at vblank.
> >  */
> 
> You want me to include that comment somewhere in the code?

Please, would be useful for future archaeologists. I'd pick the gen3
location as it is more compact.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux