== Series Details == Series: i915: Add debugfs for requesting HDCP version URL : https://patchwork.freedesktop.org/series/77693/ State : warning == Summary == $ dim checkpatch origin/drm-tip ee34d42eee76 drm/i915: Add support for considering HDCP ver requested via debugfs a44896d4d874 drm/i915: Add a new debugfs to request HDCP version -:38: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #38: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2190: +{ + -:53: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf #53: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2205: + seq_printf(m, "Requested Versions:\n"); -:55: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf #55: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2207: + seq_printf(m, "HDCP1.4\n"); -:57: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf #57: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2209: + seq_printf(m, "HDCP2.2\n"); -:63: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #63: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2215: +static int i915_hdcp_ver_request_open(struct inode *inode, + struct file *file) -:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #84: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2236: +static ssize_t i915_hdcp_ver_request_write(struct file *file, + const char __user *ubuf, -:106: CHECK:LINE_SPACING: Please don't use multiple blank lines #106: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2258: + + -:139: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #139: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2314: + debugfs_create_file("i915_hdcp_version_request", S_IRUGO, root, total: 0 errors, 4 warnings, 4 checks, 110 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx