> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Vandita
> Kulkarni
> Sent: Monday, May 4, 2020 1:19 PM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH] drm/i915/display: Fix the encoder type check
>
> For all ddi, encoder->type holds output type as ddi, assigning it to individual o/p
> types is no more valid.
>
> Fixes: 362bfb995b78 ("drm/i915/tgl: Add DKL PHY vswing table for HDMI")
Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar@xxxxxxxxx>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 5601673c3f30..10d70daf714b 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2579,14 +2579,14 @@ static void icl_ddi_vswing_sequence(struct
> intel_encoder *encoder,
>
> static void
> tgl_dkl_phy_ddi_vswing_sequence(struct intel_encoder *encoder, int link_clock,
> - u32 level)
> + u32 level, enum intel_output_type type)
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> enum tc_port tc_port = intel_port_to_tc(dev_priv, encoder->port);
> const struct tgl_dkl_phy_ddi_buf_trans *ddi_translations;
> u32 n_entries, val, ln, dpcnt_mask, dpcnt_val;
>
> - if (encoder->type == INTEL_OUTPUT_HDMI) {
> + if (type == INTEL_OUTPUT_HDMI) {
> n_entries = ARRAY_SIZE(tgl_dkl_phy_hdmi_ddi_trans);
> ddi_translations = tgl_dkl_phy_hdmi_ddi_trans;
> } else {
> @@ -2638,7 +2638,7 @@ static void tgl_ddi_vswing_sequence(struct
> intel_encoder *encoder,
> if (intel_phy_is_combo(dev_priv, phy))
> icl_combo_phy_ddi_vswing_sequence(encoder, level, type);
> else
> - tgl_dkl_phy_ddi_vswing_sequence(encoder, link_clock, level);
> + tgl_dkl_phy_ddi_vswing_sequence(encoder, link_clock, level,
> type);
> }
>
> static u32 translate_signal_level(struct intel_dp *intel_dp, int signal_levels)
> --
> 2.21.0.5.gaeb582a
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
