On Fri, 24 Jan 2020, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote: > There's a lot of display (watermark) code in intel_pm.c as well, even > though it doesn't live in the display/ directory. We should probably > pull the watermark stuff out into a separate display/intel_wm.c or > something soon, but in the meantime we'll probably want to switch a > bunch of that code over to using these new functions. But I guess you > can't do that with coccinelle though since there are parts of the file > that aren't display-related and shouldn't use the same display helpers. Yeah, display/ was a clear-cut line. I may have already pushed some patches using intel_de_*_fw from the top level code, but I think it would be better to move all large chunks of code that do display uncore stuff under display/. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
