On Thu, 23 Jan 2020, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > Quoting Ville Syrjälä (2020-01-23 14:16:46) >> On Thu, Jan 23, 2020 at 04:00:04PM +0200, Jani Nikula wrote: >> > Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and >> > switch to using intel_de_read_fw() and intel_de_write_fw(), >> > respectively. >> > >> > No functional changes. >> > >> > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> >> Only a few oddities spotted. Overall series lgtm > > Concurred, checkpatch is going to have some very stern words regarding > some of those lines! > >> For all >> Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > +1 > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Thanks for the reviews, I pushed the ones *not* in display/ with hopes we'll do the mass conversion there (the other series). BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
