On Mon, 29 Oct 2012 15:20:15 +0000 "Lespiau, Damien" <damien.lespiau at intel.com> wrote: > On Sun, Oct 28, 2012 at 10:04 AM, Chris Wilson <chris at chris-wilson.co.uk> wrote: > > We do. However, we don't catch userspace changing the tiling on an > > existing fb (unless actually pinned)... The extra level of defense is > > certainly welcome, and provides documentation at all levels on the known > > capabilities of the hw. (The only downside is that we have more guards to > > fixup if those ever change, but unlikely ;) > > I've sent a new version of this one then, turns out it be useful to > catch cases where one changes the tiling mode after the creation of > the fb. > Ok sounds good. I'll add my r-b to the latest one. -- Jesse Barnes, Intel Open Source Technology Center