Re: [PATCH v3 2/2] drm/i915/tgl: MOCS table update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matt Roper <matthew.d.roper@xxxxxxxxx> writes:

> The bspec was just updated with a minor correction to entry 61 (it
> shouldn't have had the SCF bit set).
>
> v2:
>  - Add a MOCS_ENTRY_UNUSED() and use it to declare the
>    explicitly-reserved MOCS entries. (Lucas)
>  - Move the warning suppression from the Makefile to a #pragma that only
>    affects the TGL table. (Lucas)
>
> v3:
>  - Entries 16 and 17 are identical to ICL now, so no need to explicitly
>    adjust them (or mess with compiler warning overrides).
>
> Bspec: 45101
> Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
> Cc: Tomasz Lis <tomasz.lis@xxxxxxxxx>
> Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> Cc: Francisco Jerez <francisco.jerez.plata@xxxxxxxxx>
> Cc: Jon Bloomfield <jon.bloomfield@xxxxxxxxx>
> Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx>

Reviewed-by: Francisco Jerez <currojerez@xxxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
> index 06e2adbf27be..2b977991b785 100644
> --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
> @@ -263,7 +263,7 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
>  		   L3_1_UC),
>  	/* HW Special Case (Displayable) */
>  	MOCS_ENTRY(61,
> -		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
> +		   LE_1_UC | LE_TC_1_LLC,
>  		   L3_3_WB),
>  };
>  
> -- 
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux