Matt Roper <matthew.d.roper@xxxxxxxxx> writes:
> This reverts commit f4071997f1de016780ec6b79c63d90cd5886ee83.
>
> These extra EHL entries won't behave as expected without a bit more work
> on the kernel side so let's drop them until that kernel work has had a
> chance to land. Userspace trying to use these new entries won't get the
> advantage of the new functionality these entries are meant to provide,
> but at least it won't misbehave.
>
> When we do add these back in the future, we'll probably want to
> explicitly use separate tables for ICL and EHL so that userspace
> software that mistakenly uses these entries (which are undefined on ICL)
> sees the same behavior it sees with all the other undefined entries.
>
> Cc: Francisco Jerez <francisco.jerez.plata@xxxxxxxxx>
> Cc: Jon Bloomfield <jon.bloomfield@xxxxxxxxx>
> Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
I think f4071997f1de016780ec6b79c63d90cd5886ee83 has hit a few kernel
releases already. Wouldn't it make sense to CC stable?
Patch is:
Reviewed-by: Francisco Jerez <currojerez@xxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/gt/intel_mocs.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
> index 6e881c735b20..06e2adbf27be 100644
> --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
> @@ -200,14 +200,6 @@ static const struct drm_i915_mocs_entry broxton_mocs_table[] = {
> MOCS_ENTRY(15, \
> LE_3_WB | LE_TC_1_LLC | LE_LRUM(2) | LE_AOM(1), \
> L3_3_WB), \
> - /* Bypass LLC - Uncached (EHL+) */ \
> - MOCS_ENTRY(16, \
> - LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \
> - L3_1_UC), \
> - /* Bypass LLC - L3 (Read-Only) (EHL+) */ \
> - MOCS_ENTRY(17, \
> - LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \
> - L3_3_WB), \
> /* Self-Snoop - L3 + LLC */ \
> MOCS_ENTRY(18, \
> LE_3_WB | LE_TC_1_LLC | LE_LRUM(3) | LE_SSE(3), \
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
