== Series Details == Series: Refactor Gen11+ SAGV support (rev3) URL : https://patchwork.freedesktop.org/series/68028/ State : warning == Summary == $ dim checkpatch origin/drm-tip ffa7a93754dd drm/i915: Refactor intel_can_enable_sagv -:94: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #94: FILE: drivers/gpu/drm/i915/intel_pm.c:3840: + for_each_new_intel_crtc_in_state(state, crtc, + new_crtc_state, i) { -:95: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #95: FILE: drivers/gpu/drm/i915/intel_pm.c:3841: + new_crtc_state, i) { + -:111: ERROR:OPEN_BRACE: that open brace { should be on the previous line #111: FILE: drivers/gpu/drm/i915/intel_pm.c:3857: + for (level = ilk_wm_max_level(dev_priv); + !wm->wm[level].plane_en; --level) + { } -:160: WARNING:LINE_SPACING: Missing a blank line after declarations #160: FILE: drivers/gpu/drm/i915/intel_pm.c:4032: + u32 latency = dev_priv->wm.skl_latency[level]; + skl_compute_plane_wm(crtc_state, level, latency, &wp, &wm, &wm); -:170: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #170: FILE: drivers/gpu/drm/i915/intel_pm.c:4386: +tgl_check_pipe_fits_sagv_wm(struct intel_crtc_state *crtc_state, + struct skl_ddb_allocation *ddb /* out */) -:195: CHECK:LINE_SPACING: Please don't use multiple blank lines #195: FILE: drivers/gpu/drm/i915/intel_pm.c:4411: + + -:228: WARNING:BRACES: braces {} are not necessary for single statement blocks #228: FILE: drivers/gpu/drm/i915/intel_pm.c:4444: + if (blocks > alloc_size) { + return -ENOSPC; + } -:291: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #291: FILE: drivers/gpu/drm/i915/intel_pm.c:5038: + skl_compute_plane_wm(crtc_state, level, latency, + wm_params, result_prev, -:294: ERROR:TRAILING_WHITESPACE: trailing whitespace #294: FILE: drivers/gpu/drm/i915/intel_pm.c:5041: +^I^I^Ielse $ -:294: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #294: FILE: drivers/gpu/drm/i915/intel_pm.c:5041: + } + else -:296: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #296: FILE: drivers/gpu/drm/i915/intel_pm.c:5043: + memcpy(&plane_wm->sagv_wm_l0, &levels[0], + sizeof(struct skl_wm_level)); -:375: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #375: FILE: drivers/gpu/drm/i915/intel_pm.c:5780: + for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, + new_crtc_state, i) { -:377: WARNING:LINE_SPACING: Missing a blank line after declarations #377: FILE: drivers/gpu/drm/i915/intel_pm.c:5782: + struct intel_plane *plane; + for_each_intel_plane_on_crtc(&dev_priv->drm, crtc, plane) { -:379: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #379: FILE: drivers/gpu/drm/i915/intel_pm.c:5784: + struct skl_plane_wm *plane_wm = \ -:383: WARNING:LINE_SPACING: Missing a blank line after declarations #383: FILE: drivers/gpu/drm/i915/intel_pm.c:5788: + struct skl_wm_level *l0_wm0 = &plane_wm->wm[0]; + memcpy(l0_wm0, sagv_wm0, sizeof(struct skl_wm_level)); total: 3 errors, 5 warnings, 7 checks, 339 lines checked 601d1798c1e2 drm/i915: Restrict qgv points which don't have enough bandwidth. -:125: CHECK:LINE_SPACING: Please don't use multiple blank lines #125: FILE: drivers/gpu/drm/i915/display/intel_bw.c:138: + + -:330: CHECK:BRACES: braces {} should be used on all arms of this statement #330: FILE: drivers/gpu/drm/i915/display/intel_display.c:14644: + if (INTEL_GEN(dev_priv) < 11) { [...] + else [...] -:334: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #334: FILE: drivers/gpu/drm/i915/display/intel_display.c:14648: + } + else total: 1 errors, 0 warnings, 2 checks, 298 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
