Op 07-10-2019 om 21:37 schreef Matt Roper: > On Fri, Oct 04, 2019 at 01:34:54PM +0200, Maarten Lankhorst wrote: >> We have a src and dect rectangle, use it instead of relying on >> the core drm properties. >> >> This removes the special case in the watermark code for cursor w/h. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > I think you should make it more clear in the commit message here that > you're actually overwriting the clipped coordinates in src/dst with the > unclipped coordinates that we program into our hardware. I missed that > the first time reading through the patch; using clipped coordinates > would obviously cause lots of failures. > > Actually, even if this is safe at the moment, we're violating the > documented expectations of the DRM core. I'd suggest also adding a drm > core patch that updates the comment on drm_plane_state to indicate that > the contents may or may not be clipped (driver-specific) and that the > core shouldn't assume either way. Updated the core's expectations, to explicitly allow the unclipped coordinates, and pushed patch 2-6 with the feedback. Thanks for reviews all. :) ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
