The first approach centered on ensuring that bigjoiner had a separate master_plane_state and slave_plane_state, this complicated the code too much. The new approach performs the same uapi and hw split as I did for crtc_state, and allows bigjoiner to work with very small modifications in comparison to the first approach. The bigjoiner implementation itself is now only: 14 files changed, 1269 insertions(+), 417 deletions(-) Compared to the massive changes before, I like it. :) Maarten Lankhorst (23): HAX to make DSC work on the icelake test system drm/i915: Fix for_each_intel_plane_mask definition drm/i915: Introduce and use intel_atomic_crtc_state_for_each_plane_state. drm/i915: Remove cursor use of properties for coordinates drm/i915: Use intel_plane_state in prepare and cleanup plane_fb drm/i915: Remove begin/finish_crtc_commit, v4. drm/i915: Introduce intel_atomic_get_plane_state_after_check() drm/i915: Prepare to split crtc state in uapi and hw state drm/i915: Handle a few more cases for crtc hw/uapi split drm/i915: Complete crtc hw/uapi split, v2. drm/i915: Preparation for plane split drm/i915: Split plane hw and uapi state drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v2. drm/i915: Try to make bigjoiner work in atomic check, v2. drm/i915: Enable big joiner support in enable and disable sequences. drm/i915: Make hardware readout work on i915. drm/i915: Remove special case slave handling during hw programming drm/i915: Link planes in a bigjoiner configuration, v2. drm/i915: Add bigjoiner aware plane clipping checks drm/i915: Ensure color blobs are copied to slave before planes are checked drm/i915: Add intel_update_bigjoiner handling. drm/i915: Add debugfs dumping for bigjoiner, v2. semi-hax: drm/i915: Always verify ddb allocation Ville Syrjälä (1): drm/i915: Stop using drm_atomic_helper_check_planes() drivers/gpu/drm/drm_dp_helper.c | 4 +- drivers/gpu/drm/i915/display/icl_dsi.c | 18 +- drivers/gpu/drm/i915/display/intel_atomic.c | 108 +- drivers/gpu/drm/i915/display/intel_atomic.h | 3 + .../gpu/drm/i915/display/intel_atomic_plane.c | 249 +- .../gpu/drm/i915/display/intel_atomic_plane.h | 12 +- drivers/gpu/drm/i915/display/intel_audio.c | 12 +- drivers/gpu/drm/i915/display/intel_bw.c | 4 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 31 +- drivers/gpu/drm/i915/display/intel_color.c | 187 +- drivers/gpu/drm/i915/display/intel_crt.c | 24 +- drivers/gpu/drm/i915/display/intel_ddi.c | 89 +- drivers/gpu/drm/i915/display/intel_display.c | 2208 +++++++++++------ drivers/gpu/drm/i915/display/intel_display.h | 20 +- .../drm/i915/display/intel_display_types.h | 100 +- drivers/gpu/drm/i915/display/intel_dp.c | 173 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 8 +- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 14 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 20 +- drivers/gpu/drm/i915/display/intel_dvo.c | 14 +- drivers/gpu/drm/i915/display/intel_fbc.c | 22 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 64 +- drivers/gpu/drm/i915/display/intel_lspcon.c | 4 +- drivers/gpu/drm/i915/display/intel_lvds.c | 12 +- drivers/gpu/drm/i915/display/intel_overlay.c | 4 +- drivers/gpu/drm/i915/display/intel_panel.c | 14 +- drivers/gpu/drm/i915/display/intel_pipe_crc.c | 6 +- drivers/gpu/drm/i915/display/intel_psr.c | 14 +- drivers/gpu/drm/i915/display/intel_sdvo.c | 22 +- drivers/gpu/drm/i915/display/intel_sprite.c | 295 ++- drivers/gpu/drm/i915/display/intel_sprite.h | 3 +- drivers/gpu/drm/i915/display/intel_tv.c | 8 +- drivers/gpu/drm/i915/display/intel_vdsc.c | 134 +- drivers/gpu/drm/i915/display/intel_vdsc.h | 2 + drivers/gpu/drm/i915/display/vlv_dsi.c | 20 +- drivers/gpu/drm/i915/i915_debugfs.c | 63 +- drivers/gpu/drm/i915/intel_pm.c | 381 ++- include/drm/drm_dp_helper.h | 1 + 38 files changed, 2718 insertions(+), 1649 deletions(-) -- 2.23.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx