== Series Details == Series: uC fw path unification + misc clean-up (rev2) URL : https://patchwork.freedesktop.org/series/64039/ State : warning == Summary == $ dim checkpatch origin/drm-tip eb041c6704a9 drm/i915/uc: Unify uC platform check e49692394e57 drm/i915/uc: Unify uC FW selection -:244: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #244: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:36: +#define INTEL_UC_FIRMWARE_DEFS(fw_def, guc_def, huc_def) \ + fw_def(ICELAKE, 0, guc_def(icl, 33, 0, 0), huc_def(icl, 8, 4, 3238)) \ + fw_def(COFFEELAKE, 0, guc_def(kbl, 33, 0, 0), huc_def(kbl, 02, 00, 1810)) \ + fw_def(GEMINILAKE, 0, guc_def(glk, 33, 0, 0), huc_def(glk, 03, 01, 2893)) \ + fw_def(KABYLAKE, 0, guc_def(kbl, 33, 0, 0), huc_def(kbl, 02, 00, 1810)) \ + fw_def(BROXTON, 0, guc_def(bxt, 33, 0, 0), huc_def(bxt, 01, 8, 2893)) \ + fw_def(SKYLAKE, 0, guc_def(skl, 33, 0, 0), huc_def(skl, 01, 07, 1398)) -:244: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fw_def' - possible side-effects? #244: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:36: +#define INTEL_UC_FIRMWARE_DEFS(fw_def, guc_def, huc_def) \ + fw_def(ICELAKE, 0, guc_def(icl, 33, 0, 0), huc_def(icl, 8, 4, 3238)) \ + fw_def(COFFEELAKE, 0, guc_def(kbl, 33, 0, 0), huc_def(kbl, 02, 00, 1810)) \ + fw_def(GEMINILAKE, 0, guc_def(glk, 33, 0, 0), huc_def(glk, 03, 01, 2893)) \ + fw_def(KABYLAKE, 0, guc_def(kbl, 33, 0, 0), huc_def(kbl, 02, 00, 1810)) \ + fw_def(BROXTON, 0, guc_def(bxt, 33, 0, 0), huc_def(bxt, 01, 8, 2893)) \ + fw_def(SKYLAKE, 0, guc_def(skl, 33, 0, 0), huc_def(skl, 01, 07, 1398)) -:244: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'guc_def' - possible side-effects? #244: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:36: +#define INTEL_UC_FIRMWARE_DEFS(fw_def, guc_def, huc_def) \ + fw_def(ICELAKE, 0, guc_def(icl, 33, 0, 0), huc_def(icl, 8, 4, 3238)) \ + fw_def(COFFEELAKE, 0, guc_def(kbl, 33, 0, 0), huc_def(kbl, 02, 00, 1810)) \ + fw_def(GEMINILAKE, 0, guc_def(glk, 33, 0, 0), huc_def(glk, 03, 01, 2893)) \ + fw_def(KABYLAKE, 0, guc_def(kbl, 33, 0, 0), huc_def(kbl, 02, 00, 1810)) \ + fw_def(BROXTON, 0, guc_def(bxt, 33, 0, 0), huc_def(bxt, 01, 8, 2893)) \ + fw_def(SKYLAKE, 0, guc_def(skl, 33, 0, 0), huc_def(skl, 01, 07, 1398)) -:244: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'huc_def' - possible side-effects? #244: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:36: +#define INTEL_UC_FIRMWARE_DEFS(fw_def, guc_def, huc_def) \ + fw_def(ICELAKE, 0, guc_def(icl, 33, 0, 0), huc_def(icl, 8, 4, 3238)) \ + fw_def(COFFEELAKE, 0, guc_def(kbl, 33, 0, 0), huc_def(kbl, 02, 00, 1810)) \ + fw_def(GEMINILAKE, 0, guc_def(glk, 33, 0, 0), huc_def(glk, 03, 01, 2893)) \ + fw_def(KABYLAKE, 0, guc_def(kbl, 33, 0, 0), huc_def(kbl, 02, 00, 1810)) \ + fw_def(BROXTON, 0, guc_def(bxt, 33, 0, 0), huc_def(bxt, 01, 8, 2893)) \ + fw_def(SKYLAKE, 0, guc_def(skl, 33, 0, 0), huc_def(skl, 01, 07, 1398)) -:252: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'separator_' - possible side-effects? #252: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:44: +#define __MAKE_UC_FW_PATH(prefix_, name_, separator_, major_, minor_, patch_) \ + "i915/" \ + __stringify(prefix_) name_ \ + __stringify(major_) separator_ \ + __stringify(minor_) separator_ \ + __stringify(patch_) ".bin" -:266: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #266: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:58: +#define INTEL_UC_MODULE_FW(platform_, revid_, guc_, huc_) \ + MODULE_FIRMWARE(guc_); \ + MODULE_FIRMWARE(huc_); -:266: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #266: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:58: +#define INTEL_UC_MODULE_FW(platform_, revid_, guc_, huc_) \ + MODULE_FIRMWARE(guc_); \ + MODULE_FIRMWARE(huc_); -:285: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'major_' - possible side-effects? #285: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:77: +#define GUC_FW_BLOB(prefix_, major_, minor_, patch_) \ + UC_FW_BLOB(major_, minor_, \ + MAKE_GUC_FW_PATH(prefix_, major_, minor_, patch_)) -:285: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'minor_' - possible side-effects? #285: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:77: +#define GUC_FW_BLOB(prefix_, major_, minor_, patch_) \ + UC_FW_BLOB(major_, minor_, \ + MAKE_GUC_FW_PATH(prefix_, major_, minor_, patch_)) -:289: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'major_' - possible side-effects? #289: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:81: +#define HUC_FW_BLOB(prefix_, major_, minor_, bld_num_) \ + UC_FW_BLOB(major_, minor_, \ + MAKE_HUC_FW_PATH(prefix_, major_, minor_, bld_num_)) -:289: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'minor_' - possible side-effects? #289: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:81: +#define HUC_FW_BLOB(prefix_, major_, minor_, bld_num_) \ + UC_FW_BLOB(major_, minor_, \ + MAKE_HUC_FW_PATH(prefix_, major_, minor_, bld_num_)) total: 2 errors, 1 warnings, 8 checks, 408 lines checked 0de179e2f693 drm/i915/uc: Unify uc_fw status tracking -:48: WARNING:LINE_SPACING: Missing a blank line after declarations #48: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c:236: + int ret = intel_uc_fw_upload(&guc->fw, guc_fw_xfer); + if (!ret) total: 0 errors, 1 warnings, 0 checks, 391 lines checked f9e37db54a35 drm/i915/uc: Move xfer rsa logic to common function dbfa2f355568 drm/i915/huc: Copy huc rsa only once be285c278fbb drm/i915/guc: Set GuC init params only once 44723e28e673 drm/i915/uc: Plumb the gt through fw_upload 30835ba789c4 drm/i915/uc: Unify uC firmware upload _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
