Re: [RFC] drm/i915/hangcheck: Look at instdone for all engines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2019-06-10 14:01:10)
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> It seems intel_engine_get_instdone is able to get instdone for all engines
> but intel_hangcheck.c/subunits_stuck decides to ignore it for non render.
> 
> We can just drop the check in subunits_stuck since the checks on
> unavailable fields will always return stuck, which when bitwise and with
> the potential unstuck instdone is harmless.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> ---
> Would actually using the available data improve hang detection?

I got hung up on this question, and didn't address the patch on its
merits.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux