Re: [PATCH 03/33] drm/i915: Move intel_gt initialization to a separate file

[Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>]

Quoting Tvrtko Ursulin (2019-06-19 14:24:29)
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> As it will grow in a following patch make a new home for it.
> 
> v2:
>  * Convert mock_gem_device as well. (Chris)
> 
> v3:
>  * Rename to intel_gt_init_early and move call site to i915_drv.c. (Chris)
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> # v2
> ---
>  drivers/gpu/drm/i915/Makefile                    |  1 +
>  drivers/gpu/drm/i915/gt/intel_gt.c               | 15 +++++++++++++++
>  drivers/gpu/drm/i915/gt/intel_gt.h               | 14 ++++++++++++++
>  drivers/gpu/drm/i915/i915_drv.c                  |  3 +++
>  drivers/gpu/drm/i915/i915_gem.c                  |  4 ----
>  drivers/gpu/drm/i915/selftests/mock_gem_device.c |  6 ++----
>  6 files changed, 35 insertions(+), 8 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/gt/intel_gt.c
>  create mode 100644 drivers/gpu/drm/i915/gt/intel_gt.h
> 
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 91355c2ea8a5..19f8b6745772 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -74,6 +74,7 @@ gt-y += \
>         gt/intel_context.o \
>         gt/intel_engine_cs.o \
>         gt/intel_engine_pm.o \
> +       gt/intel_gt.o \
>         gt/intel_gt_pm.o \
>         gt/intel_hangcheck.o \
>         gt/intel_lrc.o \
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
> new file mode 100644
> index 000000000000..29a0f0a32549
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> @@ -0,0 +1,15 @@
> +/*
> + * SPDX-License-Identifier: MIT
> + *
> + * Copyright © 2019 Intel Corporation
> + */
> +
> +#include "intel_gt.h"
> +
> +void intel_gt_init_early(struct intel_gt *gt)
> +{
> +       INIT_LIST_HEAD(&gt->active_rings);
> +       INIT_LIST_HEAD(&gt->closed_vma);
> +
> +       spin_lock_init(&gt->closed_lock);
> +}
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h
> new file mode 100644
> index 000000000000..d153e7fb4c08
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.h
> @@ -0,0 +1,14 @@
> +/*
> + * SPDX-License-Identifier: MIT
> + *
> + * Copyright © 2019 Intel Corporation
> + */
> +
> +#ifndef __INTEL_GT__
> +#define __INTEL_GT__
> +
> +#include "gt/intel_gt_types.h"

Inside gt/ we don't need to use the gt/ prefix for includes.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx