Re: [PATCH 02/33] drm/i915: Introduce struct intel_gt as replacement for anonymous i915->gt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 19/06/2019 15:20, Jani Nikula wrote:
On Wed, 19 Jun 2019, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
Quoting Jani Nikula (2019-06-19 14:48:30)
On Wed, 19 Jun 2019, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

We have long been slighlty annoyed by the anonymous i915->gt.

Promote it to a separate structure and give it its own header.

This is a first step towards cleaning up the separation between i915 and gt.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
---
  drivers/gpu/drm/i915/gt/intel_gt_types.h | 53 ++++++++++++++++++++++++
  drivers/gpu/drm/i915/i915_drv.h          | 34 +--------------
  2 files changed, 55 insertions(+), 32 deletions(-)
  create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_types.h

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h
new file mode 100644
index 000000000000..dcdb18e0dd84
--- /dev/null
+++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h
@@ -0,0 +1,53 @@
+/*
+ * SPDX-License-Identifier: MIT
+ *
+ * Copyright © 2019 Intel Corporation
+ */

http://patchwork.freedesktop.org/patch/msgid/20190615043142.GA1890@nishad

I utterly abhor that. Breaking prior coding style and consistency just
for the sake of a perl script. I want the copyright information as part
of the licence grant (as it is who is giving the licence grant in the first
place).

Aesthetically speaking, I'm with you.

It's just that the powers that be have in their infinite wisdom decided
on the one true style (*) to add SPDX headers.

I'll look the other way, but I'm also not going to block patches adding
new files with "conforming" headers. I'm not sure how long we'll be able
to fend off patches converting existing headers, especially given that
SPDX headers were (and I think are being) added directly to Linus' tree
bypassing subsystem trees.

Fair enough?

I can convert this before merging no problem. If nothing else will keep checkpatch quieter so at least some benefit.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux