Quoting Tvrtko Ursulin (2019-06-14 10:51:59) > > On 13/06/2019 15:08, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-06-13 14:35:31) > >> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > >> > >> Having made start to better code compartmentalization by introducing > >> struct intel_gt, continue the theme elsewhere in code by making functions > >> take parameters take what logically makes most sense for them instead of > >> the global struct drm_i915_private. > > > > So I am debating whether this is better off as part of i915_ggtt and not > > i915_address_space. > > In terms of what object is passed in? No, I was thinking placement of the intel_gt backpointer. Just trying to assess whether i915_address_space is an abstract concept... But it needs to be tied to a struct device for dma_mapping, so I think I am talking rubbish. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx