On Mon, May 27, 2019 at 08:13:06AM +0200, Daniel Vetter wrote: > On Sat, May 25, 2019 at 05:01:59PM +0200, Sam Ravnborg wrote: > > Hi Daniel > > > > > It's dead code, and removing it avoids me having to understand > > > what it's doing with lock_fb_info. > > > > I pushed the series through my build tests which include the sh > > architecture. > > > > One error and one warning was triggered from sh_mobile_lcdcfb.c. > > The rest was fine. > > > > The patch below removed the sole user of > > sh_mobile_lcdc_must_reconfigure() so this triggers a warning. > > > > And I also get the following error: > > drivers/video/fbdev/sh_mobile_lcdcfb.c: In function ‘sh_mobile_fb_reconfig’: > > drivers/video/fbdev/sh_mobile_lcdcfb.c:1800:2: error: implicit declaration of function ‘fbcon_update_vcs’; did you mean ‘file_update_time’? [-Werror=implicit-function-declaration] > > fbcon_update_vcs(info, true); > > ^~~~~~~~~~~~~~~~ > > file_update_time > > > > I did not check but assume the error was triggered in patch 28 where > > fbcon_update_vcs() in introduced. > > Oops. Can I have your sob so I can squash this in? Yes, here we go. (It was trivial so I thought not needed, sorry) Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
