Quoting Michal Wajdeczko (2019-05-17 17:22:27) > When we reset engines using ALL_ENGINES mask, we will do > full GPU reset and GuC will be also affected. Let GuC be > prepared for upcoming reset. > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > --- > drivers/gpu/drm/i915/gt/intel_reset.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c > index 464369bc55ad..ca6e40b6b4e2 100644 > --- a/drivers/gpu/drm/i915/gt/intel_reset.c > +++ b/drivers/gpu/drm/i915/gt/intel_reset.c > @@ -564,6 +564,10 @@ static int gen8_reset_engines(struct drm_i915_private *i915, > */ > } > > + /* We are about to do full GPU reset, don't forget about GuC */ > + if (engine_mask == ALL_ENGINES) > + intel_uc_reset_prepare(i915); Eh, this is done in reset_prepare already. The only other path to call intel_gpu_reset() directly is along sanitization, which should also have already sanitized the guc as well. No? -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx