Re: [PATCH 7/7] drm/i915/icl: Don't warn on spurious interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Mika Kuoppala (2019-04-10 11:59:23)
> There is a chance we can see spurious interrupts in live
> now. We have more engines enabled and that with more elaborate
> access patterns with pm and display, increases the chances
> hardware just makes a social call, without anything to work on.
> 
> Remove the error as we have tests to actually probe if
> we really miss interrupt, instead of getting spurious ones.
> 
> Note that now we do write to intr_dw even with a zero
> value. This is considered advantegous as the write
> is an ack that sw is done.

Writing 0 back to 0 handled interrupts seems fair.
 
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

I think both interrupt handling patches should go in first, as they are
bug fixes that may be required even before rps is fixed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux