On 2019-03-31 00:32:52, Chris Wilson wrote: > Quoting Jordan Justen (2019-03-31 04:03:44) > > I think the change is focused mainly around setting the vm param, so > > perhaps the subject should mention that. Maybe something like: > > It's not just about that, it's the design in how create_ext is run > before registration which caters for more than just vm. The problem > already exists for the other extensions posted, I caught the bug in > create_ext_clone and overlooked that I had been exclusively using normal > ctx_setparam to manipulate the ppgtt. I guess I disagree for two reasons. 1. I think this patch only addresses the symptom with the vm param 2. It doesn't really prevent someone from adding a new param and accidentally doing the same thing. But, feel free to keep the r-b and t-b even if you don't want to change the subject line. -Jordan _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx