Re: [PATCH] drm/i915: Avoid using ctx->file_priv during construction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 30 Mar 2019 11:03:49 +0100, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:

As we only set ctx->file_priv on registering the GEM context after
construction, it is invalid to try and use it in the middle for setting

Other option would be to set ctx->file_priv ahead of gem_context_register
and use gem_context_register only for registering (per function name)

Extra bonus would be that changed here static ctx functions will continue
to take ctx as first parameter (same as other existing ctx functions)

Michal

various parameters. Indeed, we put the file_priv into struct create_ext
so that we have the right file_private available without having to look
at ctx->file_priv. However, it helps to use it!

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux