Hi Noralf. Nice! > +++ b/drivers/gpu/drm/drm_panic.c > @@ -0,0 +1,363 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright 2018 Noralf Trønnes > + > +#include <linux/debugfs.h> > +#include <linux/font.h> > +#include <linux/kernel.h> > +#include <linux/kmsg_dump.h> > +#include <linux/seq_file.h> > +#include <linux/slab.h> > +#include <linux/uaccess.h> > + > +#include <drm/drm_crtc.h> > +#include <drm/drm_device.h> > +#include <drm/drm_drv.h> > +#include <drm/drm_file.h> > +#include <drm/drm_framebuffer.h> > +#include <drm/drm_fb_helper.h> > +#include <drm/drm_plane.h> > +#include <drm/drm_print.h> > +#include <drm/drmP.h> Please do not use drmP.h in new stuff. And res-sort the list of include files when add it. I did not read much further, so no further pedantic comments in this round. Sam _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
