== Series Details == Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev8) URL : https://patchwork.freedesktop.org/series/51878/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8bd133c09121 drm/i915: Reorganize plane register writes to make them more atomic aacf9460a2ab drm/i915: Move single buffered plane register writes to the end 76b702a28cf6 drm/i915: Introduce crtc_state->update_planes bitmask a3f9718005f5 drm/i915: Pass the new crtc_state to ->disable_plane() -:153: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #153: FILE: drivers/gpu/drm/i915/intel_display.h:385: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:153: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plane' - possible side-effects? #153: FILE: drivers/gpu/drm/i915/intel_display.h:385: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:153: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #153: FILE: drivers/gpu/drm/i915/intel_display.h:385: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:157: WARNING:LONG_LINE: line over 100 characters #157: FILE: drivers/gpu/drm/i915/intel_display.h:389: + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ total: 0 errors, 1 warnings, 3 checks, 159 lines checked 3fabcfdc4b40 drm/i915: Fix latency==0 handling for level 0 watermark on skl+ bd9a257fc86f drm/i915: Remove some useless zeroing on skl+ wm calculations 3ce3fec74105 drm/i915: Pass the entire skl_plane_wm to skl_compute_transition_wm() b4194def78ee drm/i915: Clean up skl+ vs. icl+ watermark computation 1624810c3727 drm/i915: Don't pass dev_priv around so much 593ff87703a3 drm/i915: Move ddb/wm programming into plane update/disable hooks on skl+ -:165: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #165: FILE: drivers/gpu/drm/i915/intel_display.h:418: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:165: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects? #165: FILE: drivers/gpu/drm/i915/intel_display.h:418: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:165: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #165: FILE: drivers/gpu/drm/i915/intel_display.h:418: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:169: WARNING:LONG_LINE: line over 100 characters #169: FILE: drivers/gpu/drm/i915/intel_display.h:422: + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ -:170: WARNING:LONG_LINE: line over 100 characters #170: FILE: drivers/gpu/drm/i915/intel_display.h:423: + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ total: 0 errors, 2 warnings, 3 checks, 845 lines checked d8ab70da1a46 drm/i915: Commit skl+ planes in an order that avoids ddb overlaps 063d7c684691 drm/i915: Rename the confusing 'plane_id' to 'color_plane' 1a9bea4b3b0e drm/i915: Pass the plane to icl_program_input_csc_coeff() _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
