== Series Details == Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev2) URL : https://patchwork.freedesktop.org/series/51878/ State : warning == Summary == $ dim checkpatch origin/drm-tip 240f2c27f544 drm/i915: Nuke posting reads from plane update/disable funcs 0fba33baedea drm/i915: Clean up skl_program_scaler() 8e59cc7e9005 drm/i915: Remove the PS_PWR_GATE write from skl_program_scaler() 7c03b4e5b1ad drm/i915: Polish the skl+ plane keyval/msk/max register setup 28be8177bd68 drm/i915: Clean up skl+ PLANE_POS vs. scaler handling 7f92abec85e4 drm/i915: Reorganize plane register writes to make them more atomic 3865d3b2fe70 drm/i915: Move single buffered plane register writes to the end 1407dbc2af32 drm/i915: Generalize skl_ddb_allocation_overlaps() c9f5cdb96fbd drm/i915: Introduce crtc_state->update_planes bitmask b7f0fb03ec21 drm/i915: Pass the new crtc_state to ->disable_plane() -:150: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #150: FILE: drivers/gpu/drm/i915/intel_display.h:385: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:150: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plane' - possible side-effects? #150: FILE: drivers/gpu/drm/i915/intel_display.h:385: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:150: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #150: FILE: drivers/gpu/drm/i915/intel_display.h:385: +#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_total_plane && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ + (__i)++) \ + for_each_if(plane) -:154: WARNING:LONG_LINE: line over 100 characters #154: FILE: drivers/gpu/drm/i915/intel_display.h:389: + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), 1); \ total: 0 errors, 1 warnings, 3 checks, 159 lines checked 298d98fee3c4 drm/i915: Fix latency==0 handling for level 0 watermark on skl+ d48eeb6c6519 drm/i915: Remove some useless zeroing on skl+ wm calculations 1bd36424404f drm/i915: Move ddb/wm programming into plane update/disable hooks on skl+ -:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #157: FILE: drivers/gpu/drm/i915/intel_display.h:418: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects? #157: FILE: drivers/gpu/drm/i915/intel_display.h:418: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #157: FILE: drivers/gpu/drm/i915/intel_display.h:418: +#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.dev->mode_config.num_crtc && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)++) \ + for_each_if(crtc) -:161: WARNING:LONG_LINE: line over 100 characters #161: FILE: drivers/gpu/drm/i915/intel_display.h:422: + (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \ -:162: WARNING:LONG_LINE: line over 100 characters #162: FILE: drivers/gpu/drm/i915/intel_display.h:423: + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ total: 0 errors, 2 warnings, 3 checks, 912 lines checked 5d41e9a93e3e drm/i915: Commit skl+ planes in an order that avoids ddb overlaps _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
