On Sat, Jun 30, 2012 at 08:04:44PM -0700, Ben Widawsky wrote: > On Fri, 29 Jun 2012 23:32:16 +0200 > Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > > > While creating the new enable/disable_gt_powersave functions in > > > > commit 8090c6b9daa04dda649ac0a2209601042abfb0a4 > > Author: Daniel Vetter <daniel.vetter at ffwll.ch> > > Date: Sun Jun 24 16:42:32 2012 +0200 > > > > drm/i915: wrap up gt powersave enabling functions > > > > I've botched up the handling of ironlake_disable_rc6. Fix this up by > > calling it at the right place. Note though that ironlake_disable_rc6 > > does a bit more than just disabling rc6 - it also tears down all the > > allocated context objects. > > I can only hope that one day you will appreciate the API I set up in > the context code to handle this. > > > > > Hence we need to move intel_teardown_rc6 out and directly call it from > > intel_modeset_cleanup. > > I don't mind that you've done this, however could you explain/modify the > comment when we want to disable without destroying the backing context > object? > > > > > Also properly mark ironlake_enable_rc6 as static and kill the un-used > > declaration in i915_drv.h. > > > > Cc: Ben Widawsky <ben at bwidawsk.net> > > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > Reviewed-by: Ben Widawsky <ben at bwidawsk.net> Queued for -next (with a little comment added as discussed), thanks for the review. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
