On Mon, Jul 02, 2012 at 08:44:00AM -0700, Ben Widawsky wrote: > On Sun, 1 Jul 2012 12:48:59 +0200 > Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > > Hm, I don't see the comment you're talking about ... Neither > > ironlake_disable_rc6 nor ironlake_teardown_rc6 nor any of the callers > > have one. Or am I totally missing your point? > > -Daniel > > > > iirc in the past, disabling rc6 mean disable, and destroy the object. > Now it simply means disable. If that's the case, really just a comment > in the commit would have made me happy. If it's not the case, ignore. I think in the past disabl_rc6 meant disable&destroy on ilk, but disable but not destroy on snb. I'll add a comment to the commit message to mention that. > > > > > > >> > > >> Also properly mark ironlake_enable_rc6 as static and kill the un-used > > >> declaration in i915_drv.h. > > >> > > >> Cc: Ben Widawsky <ben at bwidawsk.net> > > >> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > > > Reviewed-by: Ben Widawsky <ben at bwidawsk.net> > > Again, > Reviewed-by: Ben Widawsky <ben at bwidawsk.net> Thanks, Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
