== Series Details == Series: series starting with [1/4] drm/i915/selftests: Split preemption smoke test into threads (rev2) URL : https://patchwork.freedesktop.org/series/50329/ State : warning == Summary == $ dim checkpatch origin/drm-tip 949446d4ae2f drm/i915/selftests: Split preemption smoke test into threads -:33: WARNING:LINE_SPACING: Missing a blank line after declarations #33: FILE: drivers/gpu/drm/i915/selftests/intel_lrc.c:605: + struct preempt_smoke *smoke = arg; + IGT_TIMEOUT(end_time); total: 0 errors, 1 warnings, 0 checks, 100 lines checked 27ea74d97340 drm/i915/selftests: Include arbitration points in preemption smoketest 8a4361322e2b drm/i915: Reserve some priority bits for internal use 05453e086003 drm/i915: Combine multiple internal plists into the same i915_priolist bucket -:167: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name #167: FILE: drivers/gpu/drm/i915/intel_lrc.c:367: + struct list_head *uninitialized_var(pl); -:285: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name #285: FILE: drivers/gpu/drm/i915/intel_lrc.c:1179: + struct list_head *uninitialized_var(pl); -:314: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects? #314: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:199: +#define priolist_for_each_request(it, plist, idx) \ + for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \ + list_for_each_entry(it, &(plist)->requests[idx], sched.link) -:314: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #314: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:199: +#define priolist_for_each_request(it, plist, idx) \ + for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \ + list_for_each_entry(it, &(plist)->requests[idx], sched.link) -:318: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects? #318: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:203: +#define priolist_for_each_request_consume(it, n, plist, idx) \ + for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \ + list_for_each_entry_safe(it, n, \ + &(plist)->requests[idx - 1], \ + sched.link) -:318: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #318: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:203: +#define priolist_for_each_request_consume(it, n, plist, idx) \ + for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \ + list_for_each_entry_safe(it, n, \ + &(plist)->requests[idx - 1], \ + sched.link) total: 0 errors, 2 warnings, 4 checks, 272 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
