On Fri, Aug 17, 2018 at 11:02:41AM +0100, Chris Wilson wrote:
> If the display has been disabled by modparam, we still want to connect
> together the HW bits and bobs with the associated drivers so that we can
> continue to manage their runtime power gating.
>
> Fixes: 108109444ff6 ("drm/i915: Check num_pipes before initializing audio component")
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Imre Deak <imre.deak@xxxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Cc: Elaine Wang <elaine.wang@xxxxxxxxx>
Going through the hooks in i915_audio_component_ops, I haven't noticed
anything that would actually go wrong with num_pipes=0. Besides some
audio HW register programming from i915_audio_component_codec_wake_override(),
we'd skip doing everything else due to not reporting any active encoders
to the audio component (as we do during normal display modeset). So
Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_audio.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index b725835b47ef..769f3f586661 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -962,9 +962,6 @@ void i915_audio_component_init(struct drm_i915_private *dev_priv)
> {
> int ret;
>
> - if (INTEL_INFO(dev_priv)->num_pipes == 0)
> - return;
> -
> ret = component_add(dev_priv->drm.dev, &i915_audio_component_bind_ops);
> if (ret < 0) {
> DRM_ERROR("failed to add audio component (%d)\n", ret);
> --
> 2.18.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
