Hi Chris, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180517] [cannot apply to drm-intel/for-linux-next v4.17-rc6 v4.17-rc5 v4.17-rc4 v4.17-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Prepare-GEM-for-suspend-earlier/20180524-224509 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/gpu/drm/i915/selftests/igt_flush_test.c:61:46: sparse: not enough arguments for function i915_gem_switch_to_kernel_context drivers/gpu/drm/i915/selftests/igt_flush_test.c: In function 'igt_flush_test': drivers/gpu/drm/i915/selftests/igt_flush_test.c:61:6: error: too few arguments to function 'i915_gem_switch_to_kernel_context' i915_gem_switch_to_kernel_context(i915)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/i915/selftests/../intel_lrc.h:28:0, from drivers/gpu/drm/i915/selftests/../i915_drv.h:63, from drivers/gpu/drm/i915/selftests/igt_flush_test.c:7: drivers/gpu/drm/i915/selftests/../i915_gem_context.h:297:5: note: declared here int i915_gem_switch_to_kernel_context(struct drm_i915_private *i915, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +61 drivers/gpu/drm/i915/selftests/igt_flush_test.c 98dc0454 Chris Wilson 2018-05-05 48 98dc0454 Chris Wilson 2018-05-05 49 #define wedge_on_timeout(W, DEV, TIMEOUT) \ 98dc0454 Chris Wilson 2018-05-05 50 for (__init_wedge((W), (DEV), (TIMEOUT), __builtin_return_address(0)); \ 98dc0454 Chris Wilson 2018-05-05 51 (W)->i915; \ 98dc0454 Chris Wilson 2018-05-05 52 __fini_wedge((W))) 98dc0454 Chris Wilson 2018-05-05 53 98dc0454 Chris Wilson 2018-05-05 54 int igt_flush_test(struct drm_i915_private *i915, unsigned int flags) 98dc0454 Chris Wilson 2018-05-05 55 { 98dc0454 Chris Wilson 2018-05-05 56 struct wedge_me w; 98dc0454 Chris Wilson 2018-05-05 57 98dc0454 Chris Wilson 2018-05-05 58 cond_resched(); 98dc0454 Chris Wilson 2018-05-05 59 b9777c6f Chris Wilson 2018-05-09 60 if (flags & I915_WAIT_LOCKED && b9777c6f Chris Wilson 2018-05-09 @61 i915_gem_switch_to_kernel_context(i915)) { :::::: The code at line 61 was first introduced by commit :::::: b9777c6f86ac8c21f82211ab982ca48302042ede drm/i915/selftests: Only switch to kernel context when locked :::::: TO: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> :::::: CC: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx