Re: [PATCH] drm/i915: Prepare GEM for suspend earlier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.17-rc6 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Prepare-GEM-for-suspend-earlier/20180524-231951
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x015-201820 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/gpu//drm/i915/i915_drv.c: In function 'i915_drm_suspend':
   drivers/gpu//drm/i915/i915_drv.c:1624:1: warning: label 'out' defined but not used [-Wunused-label]
    out:
    ^~~
>> drivers/gpu//drm/i915/i915_drv.c:1627:9: warning: 'error' is used uninitialized in this function [-Wuninitialized]
     return error;
            ^~~~~

vim +/error +1627 drivers/gpu//drm/i915/i915_drv.c

156987f3e drivers/gpu/drm/i915/i915_drv.c Chris Wilson      2018-05-22  1574  
5e365c391 drivers/gpu/drm/i915/i915_drv.c Imre Deak         2014-10-23  1575  static int i915_drm_suspend(struct drm_device *dev)
ba8bbcf6f drivers/char/drm/i915_drv.c     Jesse Barnes      2007-11-22  1576  {
fac5e23e3 drivers/gpu/drm/i915/i915_drv.c Chris Wilson      2016-07-04  1577  	struct drm_i915_private *dev_priv = to_i915(dev);
52a05c302 drivers/gpu/drm/i915/i915_drv.c David Weinehall   2016-08-22  1578  	struct pci_dev *pdev = dev_priv->drm.pdev;
e5747e3ad drivers/gpu/drm/i915/i915_drv.c Jesse Barnes      2014-06-12  1579  	pci_power_t opregion_target_state;
d58189385 drivers/gpu/drm/i915/i915_drv.c Daniel Vetter     2015-02-23  1580  	int error;
61caf87cb drivers/gpu/drm/i915/i915_drv.c Rafael J. Wysocki 2010-02-18  1581  
b8efb17b3 drivers/gpu/drm/i915/i915_drv.c Zhang Rui         2013-02-05  1582  	/* ignore lid events during suspend */
b8efb17b3 drivers/gpu/drm/i915/i915_drv.c Zhang Rui         2013-02-05  1583  	mutex_lock(&dev_priv->modeset_restore_lock);
b8efb17b3 drivers/gpu/drm/i915/i915_drv.c Zhang Rui         2013-02-05  1584  	dev_priv->modeset_restore = MODESET_SUSPENDED;
b8efb17b3 drivers/gpu/drm/i915/i915_drv.c Zhang Rui         2013-02-05  1585  	mutex_unlock(&dev_priv->modeset_restore_lock);
b8efb17b3 drivers/gpu/drm/i915/i915_drv.c Zhang Rui         2013-02-05  1586  
1f814daca drivers/gpu/drm/i915/i915_drv.c Imre Deak         2015-12-16  1587  	disable_rpm_wakeref_asserts(dev_priv);
1f814daca drivers/gpu/drm/i915/i915_drv.c Imre Deak         2015-12-16  1588  
c67a470b1 drivers/gpu/drm/i915/i915_drv.c Paulo Zanoni      2013-08-19  1589  	/* We do a lot of poking in a lot of registers, make sure they work
c67a470b1 drivers/gpu/drm/i915/i915_drv.c Paulo Zanoni      2013-08-19  1590  	 * properly. */
da7e29bd5 drivers/gpu/drm/i915/i915_drv.c Imre Deak         2014-02-18  1591  	intel_display_set_init_power(dev_priv, true);
cb10799c1 drivers/gpu/drm/i915/i915_drv.c Paulo Zanoni      2013-01-25  1592  
5bcf719b7 drivers/gpu/drm/i915/i915_drv.c Dave Airlie       2010-12-07  1593  	drm_kms_helper_poll_disable(dev);
5bcf719b7 drivers/gpu/drm/i915/i915_drv.c Dave Airlie       2010-12-07  1594  
52a05c302 drivers/gpu/drm/i915/i915_drv.c David Weinehall   2016-08-22  1595  	pci_save_state(pdev);
ba8bbcf6f drivers/char/drm/i915_drv.c     Jesse Barnes      2007-11-22  1596  
6b72d4862 drivers/gpu/drm/i915/i915_drv.c Maarten Lankhorst 2015-06-01  1597  	intel_display_suspend(dev);
7d708ee40 drivers/gpu/drm/i915/i915_drv.c Imre Deak         2013-04-17  1598  
0e32b39ce drivers/gpu/drm/i915/i915_drv.c Dave Airlie       2014-05-02  1599  	intel_dp_mst_suspend(dev);
09b64267c drivers/gpu/drm/i915/i915_drv.c Dave Airlie       2014-07-23  1600  
b963291cf drivers/gpu/drm/i915/i915_drv.c Daniel Vetter     2014-09-30  1601  	intel_runtime_pm_disable_interrupts(dev_priv);
1d0d343ab drivers/gpu/drm/i915/i915_drv.c Imre Deak         2014-08-18  1602  	intel_hpd_cancel_work(dev_priv);
0e32b39ce drivers/gpu/drm/i915/i915_drv.c Dave Airlie       2014-05-02  1603  
07f9cd0b3 drivers/gpu/drm/i915/i915_drv.c Imre Deak         2014-08-18  1604  	intel_suspend_encoders(dev_priv);
07f9cd0b3 drivers/gpu/drm/i915/i915_drv.c Imre Deak         2014-08-18  1605  
712bf3644 drivers/gpu/drm/i915/i915_drv.c Ville Syrjälä     2016-10-31  1606  	intel_suspend_hw(dev_priv);
5669fcacc drivers/gpu/drm/i915/i915_drv.c Jesse Barnes      2009-02-17  1607  
275a991c0 drivers/gpu/drm/i915/i915_drv.c Tvrtko Ursulin    2016-11-16  1608  	i915_gem_suspend_gtt_mappings(dev_priv);
828c79087 drivers/gpu/drm/i915/i915_drv.c Ben Widawsky      2013-10-16  1609  
af6dc7425 drivers/gpu/drm/i915/i915_drv.c Tvrtko Ursulin    2016-12-01  1610  	i915_save_state(dev_priv);
9e06dd39f drivers/gpu/drm/i915/i915_drv.c Jesse Barnes      2009-06-22  1611  
bc87229f3 drivers/gpu/drm/i915/i915_drv.c Imre Deak         2015-11-18  1612  	opregion_target_state = suspend_to_idle(dev_priv) ? PCI_D1 : PCI_D3cold;
6f9f4b7a2 drivers/gpu/drm/i915/i915_drv.c Chris Wilson      2016-05-23  1613  	intel_opregion_notify_adapter(dev_priv, opregion_target_state);
e5747e3ad drivers/gpu/drm/i915/i915_drv.c Jesse Barnes      2014-06-12  1614  
68f60946c drivers/gpu/drm/i915/i915_drv.c Hans de Goede     2017-02-10  1615  	intel_uncore_suspend(dev_priv);
03d92e477 drivers/gpu/drm/i915/i915_drv.c Chris Wilson      2016-05-23  1616  	intel_opregion_unregister(dev_priv);
8ee1c3db9 drivers/gpu/drm/i915/i915_drv.c Matthew Garrett   2008-08-05  1617  
82e3b8c13 drivers/gpu/drm/i915/i915_drv.c Chris Wilson      2014-08-13  1618  	intel_fbdev_set_suspend(dev, FBINFO_STATE_SUSPENDED, true);
3fa016a0b drivers/gpu/drm/i915/i915_drv.c Dave Airlie       2012-03-28  1619  
62d5d69b4 drivers/gpu/drm/i915/i915_drv.c Mika Kuoppala     2014-02-25  1620  	dev_priv->suspend_count++;
62d5d69b4 drivers/gpu/drm/i915/i915_drv.c Mika Kuoppala     2014-02-25  1621  
f74ed08d5 drivers/gpu/drm/i915/i915_drv.c Imre Deak         2016-04-18  1622  	intel_csr_ucode_suspend(dev_priv);
f514c2d84 drivers/gpu/drm/i915/i915_drv.c Imre Deak         2015-10-28  1623  
1f814daca drivers/gpu/drm/i915/i915_drv.c Imre Deak         2015-12-16 @1624  out:
1f814daca drivers/gpu/drm/i915/i915_drv.c Imre Deak         2015-12-16  1625  	enable_rpm_wakeref_asserts(dev_priv);
1f814daca drivers/gpu/drm/i915/i915_drv.c Imre Deak         2015-12-16  1626  
1f814daca drivers/gpu/drm/i915/i915_drv.c Imre Deak         2015-12-16 @1627  	return error;
84b79f8d2 drivers/gpu/drm/i915/i915_drv.c Rafael J. Wysocki 2010-02-07  1628  }
84b79f8d2 drivers/gpu/drm/i915/i915_drv.c Rafael J. Wysocki 2010-02-07  1629  

:::::: The code at line 1627 was first introduced by commit
:::::: 1f814daca43a2d99248fd754eacfb8ba12449235 drm/i915: add support for checking if we hold an RPM reference

:::::: TO: Imre Deak <imre.deak@xxxxxxxxx>
:::::: CC: Imre Deak <imre.deak@xxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux