Planes with an odd width will appear to have an incorrect
stride. When the start position is odd the controller
can lock up.
Signed-off-by: Fritz Koenig <frkoenig@xxxxxxxxxx>
---
Hi,
This appears to be a limitation of the hardware that is not being
checked. Is this supported and am I not enabling it correctly?
drivers/gpu/drm/i915/intel_atomic_plane.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu/drm/i915/intel_atomic_plane.c
index 7481ce85746b..ca4553592ab9 100644
--- a/drivers/gpu/drm/i915/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/intel_atomic_plane.c
@@ -188,6 +188,21 @@ int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_
else
crtc_state->active_planes &= ~BIT(intel_plane->id);
+ /*
+ * NV12 plane is not allowed to start from an odd position or
+ * end on an odd position.
+ */
+ if (state->fb && (DRM_FORMAT_NV12 == state->fb->format->format)) {
+ if ((intel_state->base.src_w >> 16) & 1) {
+ DRM_DEBUG_KMS("Invalid Source: Yuv format does not support odd width\n");
+ return -EINVAL;
+ }
+ if ((intel_state->base.src_x >> 16) & 1) {
+ DRM_DEBUG_KMS("Invalid Source: Yuv format does not support odd x pos\n");
+ return -EINVAL;
+ }
+ }
+
return intel_plane_atomic_calc_changes(old_crtc_state,
&crtc_state->base,
old_plane_state,
--
2.17.0.441.gb46fe60e1d-goog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
