>> >> default: >> >> - WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret); >> >> + WARN_ONCE(ret, "unhandled error in %s: %x\n", __func__, ret); >> > >> > I don't see point in %x (which should be 0x%x, really), why change it? >> >> ret will return VM_FAULT_FOO which is actually a defined as hex value >> so %x will be more meaningful to print. I think WARN_ONCE() is less >> meaningful to print inside default. >> Better to remove it ? Agree ? > > Apart from we don't want to see ret. > -Chris I look back to the code again. Printing "err" instead of "ret" will reproduce the original behaviour of the code. Will send v2. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
