Re: [PATCH v2] gpu: drm: i915: Change return type to vm_fault_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Joonas Lahtinen (2018-05-15 14:49:17)
> Quoting Souptick Joarder (2018-04-17 22:02:02)
> >         default:
> > -               WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret);
> > +               WARN_ONCE(ret, "unhandled error in %s: %x\n", __func__, ret);
> 
> I don't see point in %x (which should be 0x%x, really), why change it?

More importantly, it needs to be s/ret/err/ to describe the missing case.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux