Re: [PATCH] drm/i915/selftests: Fix error checking for wait_var_timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Chris Wilson (2018-04-18 12:14:15)
> Quoting Joonas Lahtinen (2018-04-18 10:10:17)
> > Quoting Chris Wilson (2018-04-17 20:06:38)
> > > The old wait_on_atomic_t used a custom callback to perform the
> > > schedule(), which used my return semantics of reporting an error code on
> > > timeout. wait_var_event_timeout() uses the schedule() return semantics
> > > of reporting the remaining jiffies (1 if it timed out with 0 jiffies
> > > remaining!) and 0 on failure. This semantic mismatch lead to us falsely
> > > claiming a time out occurred.
> > > 
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106085
> > > Fixes: d224985a5e31 ("sched/wait, drivers/drm: Convert wait_on_atomic_t() usage to the new wait_var_event() API")
> > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > 
> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> 
> How about a backmerge of rc1 onto drm-intel-next-queued so we can apply
> the fix?

+ Jani for that

Regards, Joonas

> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux